Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dependency on Xmerl in mix.ex #1

Merged
merged 1 commit into from
Oct 9, 2015
Merged

Conversation

pokutnik
Copy link
Contributor

This one is required for including xmerl in release

This one is required for including xmerl in release
@nhu313
Copy link
Owner

nhu313 commented Oct 7, 2015

Sorry, I didn't see your pull request. I'm also pretty unfamiliar with erlang. Just to clarify, you couldn't get the code to run if xmerl is not included in the application?

@pokutnik
Copy link
Contributor Author

pokutnik commented Oct 9, 2015

Yup, when you create a "release" of a project (for example with https://github.com/bitwalker/exrm ) it packs all dependencies together based on applications setting. So when I added quinn to my apps, builded release, there were no xmerl library included, and I got module not available error in runtime.

nhu313 added a commit that referenced this pull request Oct 9, 2015
Set dependency on Xmerl in mix.ex
@nhu313 nhu313 merged commit d55015d into nhu313:master Oct 9, 2015
@nhu313
Copy link
Owner

nhu313 commented Oct 9, 2015

Thanks for pull request and explaination @pokutnik 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants