Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows build platform toolset version #705

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jul 3, 2024

Looks like the windows build agents updated recently and now platform toolset v141 did not resolve anymore giving error:

MSBuild version 17.10.4+10fbfbf2e for .NET Framework
Build started 7/3/2024 9:22:16 PM.

     1>Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" on node 1 (default targets).
     1>ValidateSolutionConfiguration:
         Building solution configuration "Debug|Win32".
     1>Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (1) is building "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (2) on node 1 (default targets).
     2>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(49,5): error MSB[8](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:9)037: The Windows SDK version 10.0.20348.0 for Desktop C++ Win32 Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj]
     2>Done Building Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (default targets) -- FAILED.

Build FAILED.

       "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.sln" (default target) (1) ->
       "D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj" (default target) (2) ->
       (_CheckWindowsSDKInstalled target) -> 
         C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(4[9](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:10),5): error MSB8037: The Windows SDK version [10](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:11).0.20348.0 for Desktop C++ Win32 Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\VireoSDK\VireoSDK\Vireo_VS\VireoCommandLine.vcxproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:[13](https://github.com/rajsite/VireoSDK/actions/runs/9784974527/job/27017023226#step:6:14).42

Which is a not great error because Windows SDK version 10.0.20348.0 is installed but I guess PlatformToolset v141 wasn't. The installed software list shows a couple things VC++ related at v142 so just went with that

@rajsite rajsite merged commit 3f0aab6 into ni:main Jul 3, 2024
6 checks passed
@rajsite rajsite deleted the test-build branch July 3, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant