Proposal to support reference counted sessions #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
reviewed
May 14, 2024
| @@ -11,6 +11,7 @@ enum SessionInitializationBehavior { | |||
| SESSION_INITIALIZATION_BEHAVIOR_UNSPECIFIED = 0; | |||
| SESSION_INITIALIZATION_BEHAVIOR_INITIALIZE_NEW = 1; | |||
| SESSION_INITIALIZATION_BEHAVIOR_ATTACH_TO_EXISTING = 2; | |||
| SESSION_INITIALIZATION_BEHAVIOR_REFERENCE_COUNTED = 3; | |||
There was a problem hiding this comment.
This conflicts with NI-VISA's extensions to this enum.
https://github.com/ni/grpc-device/wiki/Sharing-Driver-Sessions-Between-Clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add the ability for users to add a reference count to named sessions
Why should this Pull Request be merged?
The name sessions feature of grpc-device is amazing but has one major inconvenience: Close() will close the sessions for everyone holding a reference to the named session
What testing has been done?
Added unit tests so far. Will add more tests if this draft looks reasonable