-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address missing ni-scope enums. #667
Address missing ni-scope enums. #667
Conversation
Decision process for missing enums
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like some follow upon the breaking change issue, even if it's a decision to leave it as-is.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Fixes AB#1991317
What testing has been done?
Build passes. Ran validate_examples.py on niscope to find and fix changed/removed enums.
To ensure old client with new server is able to still run installed and ran the new server with these updates on a lvtest machine, on dev machine built old client protos and ran calls to Init and Configure Clock. These calls passed and operated the same when connecting to the new server on the lvtest machine and when connecting to an old server on localhost.