Updated from latest NI-SCOPE exports #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmondrik
added
the
binary-breaking
reckenro
reviewed
Oct 11, 2022
reckenro
approved these changes
Oct 11, 2022
astarche
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates metadata using actual hapigen exports:
niscope_grpc_device 23.0.0d42Breaking changes
enum CalibrationTypeswhich was not used anywhere. So this shouldn't break any client.enum NiScopeInt64AttributeValueswhich was only exposed inCheckAttributeViInt64RequestandSetAttributeViInt64Requestbut was not needed. Instead of that enum, you should use raw values for those methods.Why should this Pull Request be merged?
Task 2172471: Import 23.0.x hapigen exports into grpc-device (nidcpower, niscope)
What testing has been done?
Built locally just fine.