Update DAQmx enums and attributes scrapigen metadata & generate proto files #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated metadata
vigkre
force-pushed
the
users/vikram/generate-proto-with-updated-scrapigen
branch
from
6e10426
to
fb655d0
Compare
vigkre
force-pushed
the
users/vikram/generate-proto-with-updated-scrapigen
branch
from
fb655d0
to
9354ed9
Compare
vigkre
changed the base branch from
main
to
users/vikram/updatedaqmx-sourcefiles-v23.0
…v23.0 source file update
… v23.0 source file update
…vikram/generate-proto-with-updated-scrapigen
bkeryan
requested changes
Mar 9, 2023
…v23.0 source file update
… v23.0 source file update
vigkre
force-pushed
the
users/vikram/updatedaqmx-sourcefiles-v23.0
branch
from
b025bbc
to
8012f44
Compare
…vikram/generate-proto-with-updated-scrapigen
vigkre
changed the title
- Removed Impedance1
…vikram/generate-proto-with-updated-scrapigen
astarche
approved these changes
Mar 13, 2023
bkeryan
approved these changes
Mar 13, 2023
reckenro
approved these changes
Mar 13, 2023
vigkre
changed the title
…vikram/generate-proto-with-updated-scrapigen
…vikram/generate-proto-with-updated-scrapigen
Base automatically changed from
users/vikram/updatedaqmx-sourcefiles-v23.0
to
main
March 14, 2023 16:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
grpc-devicewith the updated scrapigen metadata (enums.py and attributes.py)Notes:
ENUMS_SHOULD_BE_USEDsuppression for enums which is not used ingrpc-devicebut are required innidaqmx-pythonfiles.Optionalparameters in metadata_validation.py file to align with newly added fields inenums.pyandattributes.pymetadata filesTesting done
generated/nidaqmxdirectory.