[PR0] Update NIDAQmx.h and other nidaqmx metadata files to v23.0 #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigkre
changed the title
bkeryan
requested changes
Mar 9, 2023
vigkre
changed the title
bkeryan
requested changes
Mar 9, 2023
bkeryan
reviewed
Mar 9, 2023
…v23.0 source file update
… v23.0 source file update
vigkre
force-pushed
the
users/vikram/updatedaqmx-sourcefiles-v23.0
branch
from
b025bbc
to
8012f44
Compare
reckenro
reviewed
Mar 10, 2023
reckenro
reviewed
Mar 10, 2023
astarche
reviewed
Mar 13, 2023
astarche
approved these changes
Mar 13, 2023
bkeryan
requested changes
Mar 13, 2023
reckenro
added
the
source-breaking
reckenro
requested changes
Mar 13, 2023
bkeryan
approved these changes
Mar 14, 2023
reckenro
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates daqmx metadata files to version 23.0
The source files that are updated to the version include,
The files are updated to the version in this https://github.com/ni/grpc-device-scrapigen/pull/136
ENUMS_SHOULD_BE_USEDto exclude enums which are not used ingrpc-devicebut are required innidaqmx-pythonfiles.Why should this Pull Request be merged?
Testing done
generated/nidaqmxdirectory and add to the PR