LVRT crash was because RTSetCleanupProc was null. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccifra
approved these changes
Aug 19, 2022
| PostLVUserEvent = (PostLVUserEvent_T)dlsym(lvModule, "PostLVUserEvent"); | ||
| Occur = (Occur_T)dlsym(lvModule, "Occur"); | ||
| RTSetCleanupProc = (RTSetCleanupProc_T)dlsym(lvModule, "RTSetCleanupProc"); | ||
| exit(grpc::StatusCode::INTERNAL); |
There was a problem hiding this comment.
Not sure calling Exit is the best thing to do here. Makes it really hard to debug especially on RT. It would be better to at least console writeline something that gives a hint.
There was a problem hiding this comment.
Yeah, I wasn't sure the right way to handle this error condition. I'd love to use whatever function writes to the NI error logs, but I assume that code probably lives in liblvrt.so, which is precisely what we would have failed to load.
Writing to stdout or stderr probably makes sense, but im not sure where that even shows up if you don't run 'lvrt' manually. Calling syslog() would probably be a good option, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed some of the way we dynamically load export symbols from liblvrt.so