Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolved rules and comments. #2

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Add resolved rules and comments. #2

merged 7 commits into from
Sep 29, 2020

Conversation

TrevorKarjanis
Copy link
Collaborator

@TrevorKarjanis TrevorKarjanis commented Sep 15, 2020 •
edited
Loading

  • Add rules and comments that have been resolved.

Notes

  • The style of the rules definition in index.js will evolve as rules are added.

Linted and tested

  • Cowa-friggin'-bunga

@TrevorKarjanis TrevorKarjanis force-pushed the add-resolved-rules branch 3 times, most recently from 70fa7f0 to dc216b6 Compare September 17, 2020 20:47
@TrevorKarjanis TrevorKarjanis marked this pull request as ready for review September 17, 2020 20:55
jattasNI
jattasNI requested changes Sep 17, 2020
View reviewed changes
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
@jattasNI
Copy link
Collaborator

Have you already reached out to Carson/David/Tim to get their feedback on this PR even if they're not yet members of the /ni org?

@TrevorKarjanis
Copy link
Collaborator Author

Have you already reached out to Carson/David/Tim to get their feedback on this PR even if they're not yet members of the /ni org?

The link is now available in the channel.

alejandro5042
alejandro5042 suggested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@alejandro5042 alejandro5042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great! I would like to see the rationale brought out of our internal PR and into the open here, since this repo is the style guide, and not my random internal PR which will be long forgotten next year.

packages/eslint-config/index.js Show resolved Hide resolved
packages/eslint-config/index.js Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
packages/eslint-config/index.js Outdated Show resolved Hide resolved
@TrevorKarjanis TrevorKarjanis merged commit 1487ad2 into ni:master Sep 29, 2020
@TrevorKarjanis TrevorKarjanis deleted the add-resolved-rules branch September 29, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@alejandro5042 alejandro5042 alejandro5042 approved these changes

@LukasKall LukasKall LukasKall approved these changes

@jattasNI jattasNI jattasNI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TrevorKarjanis @jattasNI @rajsite @alejandro5042 @LukasKall