Skip to content

Commit

Permalink
Add support for WaitForValidTimestamp to nidaqmx-python (#479)
Browse files Browse the repository at this point in the history
  • Loading branch information
DeborahOoi96 committed Feb 20, 2024
1 parent ba42d15 commit 8cac1b8
Show file tree
Hide file tree
Showing 8 changed files with 75 additions and 5 deletions.
4 changes: 4 additions & 0 deletions generated/nidaqmx/_base_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -1661,6 +1661,10 @@ def unregister_signal_event(self, task, signal_id):
def unreserve_network_device(self, device_name):
raise NotImplementedError

@abc.abstractmethod
def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
raise NotImplementedError

@abc.abstractmethod
def wait_until_task_done(self, task, time_to_wait):
raise NotImplementedError
Expand Down
8 changes: 8 additions & 0 deletions generated/nidaqmx/_grpc_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -3255,6 +3255,14 @@ def unreserve_network_device(self, device_name):
self._client.UnreserveNetworkDevice,
grpc_types.UnreserveNetworkDeviceRequest(device_name=device_name))

def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
response = self._invoke(
self._client.WaitForValidTimestamp,
grpc_types.WaitForValidTimestampRequest(
task=task, timestamp_event_raw=timestamp_event,
timeout=timeout))
return convert_timestamp_to_time(response.timestamp)

def wait_until_task_done(self, task, time_to_wait):
response = self._invoke(
self._client.WaitUntilTaskDone,
Expand Down
16 changes: 16 additions & 0 deletions generated/nidaqmx/_library_interpreter.py
Original file line number Diff line number Diff line change
Expand Up @@ -5636,6 +5636,22 @@ def unreserve_network_device(self, device_name):
device_name)
self.check_for_error(error_code)

def wait_for_valid_timestamp(self, task, timestamp_event, timeout):
timestamp = AbsoluteTime()

cfunc = lib_importer.windll.DAQmxWaitForValidTimestamp
if cfunc.argtypes is None:
with cfunc.arglock:
if cfunc.argtypes is None:
cfunc.argtypes = [
lib_importer.task_handle, ctypes.c_int32,
ctypes.c_double, ctypes.POINTER(AbsoluteTime)]

error_code = cfunc(
task, timestamp_event, timeout, ctypes.byref(timestamp))
self.check_for_error(error_code)
return timestamp.to_datetime()

def wait_until_task_done(self, task, time_to_wait):
cfunc = lib_importer.windll.DAQmxWaitUntilTaskDone
if cfunc.argtypes is None:
Expand Down
16 changes: 16 additions & 0 deletions generated/nidaqmx/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,22 @@ def stop(self):
"""
self._interpreter.stop_task(self._handle)

def wait_for_valid_timestamp(self, timestamp_event, timeout=10.0):
"""
Wait until the specified timestamp has a value.
Use this method to ensure the timestamp has a valid value to prevent an error when querying a timestamp value.
Args:
timestamp_event(nidaqmx.constants.TimestampEvent): Specifies the timestamp type to wait on.
timeout (float): Specifies the maximum amount of time in
seconds to wait for a valid timestamp.
This method returns an error if the time elapses. The
default is 10. If you set timeout (sec) to
nidaqmx.WAIT_INFINITELY, the method waits indefinitely.
"""
self._interpreter.wait_for_valid_timestamp(self._handle, timestamp_event.value, timeout)

def wait_until_done(self, timeout=10.0):
"""
Waits for the measurement or generation to complete.
Expand Down
12 changes: 9 additions & 3 deletions src/codegen/metadata/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -23606,6 +23606,11 @@
},
'WaitForValidTimestamp': {
'calling_convention': 'StdCall',
'handle_parameter': {
'ctypes_data_type': 'lib_importer.task_handle',
'cvi_name': 'taskHandle',
'python_accessor': 'self._handle'
},
'parameters': [
{
'ctypes_data_type': 'ctypes.TaskHandle',
Expand Down Expand Up @@ -23644,13 +23649,14 @@
'direction': 'out',
'is_optional_in_python': False,
'name': 'timestamp',
'python_data_type': 'DateTime',
'python_data_type': 'datetime',
'python_description': 'Specifies the timestamp type to wait on.',
'python_type_annotation': 'nidaqmx.constants.DateTime',
'python_type_annotation': 'datetime',
'type': 'CVIAbsoluteTime'
}
],
'python_codegen_method': 'no',
'python_class_name': 'Task',
'python_codegen_method': 'CustomCode',
'python_description': 'DAQmx Wait for Valid Timestamp',
'returns': 'int32'
},
Expand Down
7 changes: 6 additions & 1 deletion src/codegen/utilities/function_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,17 @@ def to_param_argtype(parameter):
if parameter.ctypes_data_type == "ctypes.TaskHandle":
return "lib_importer.task_handle"
elif parameter.python_data_type == "datetime":
return "AbsoluteTime"
if parameter.direction == "in":
return "AbsoluteTime"
else:
return f"ctypes.POINTER(AbsoluteTime)"
elif parameter.direction == "in":
# If is string input parameter, use separate custom
# argtype to convert from unicode to bytes.
if parameter.ctypes_data_type == "ctypes.c_char_p":
return "ctypes_byte_str"
elif parameter.python_data_type == "timestampEvent":
return "ctypes.c_int32"
else:
return parameter.ctypes_data_type or parameter.python_data_type
else:
Expand Down
1 change: 0 additions & 1 deletion src/codegen/utilities/interpreter_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"SetSyncPulseTimeWhen",
"SetTimingAttributeExTimestamp",
"SetTimingAttributeTimestamp",
"WaitForValidTimestamp",
# Deprecated, not working
"GetAnalogPowerUpStates",
]
Expand Down
16 changes: 16 additions & 0 deletions src/handwritten/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,22 @@ def stop(self):
"""
self._interpreter.stop_task(self._handle)

def wait_for_valid_timestamp(self, timestamp_event, timeout=10.0):
"""
Wait until the specified timestamp has a value.
Use this method to ensure the timestamp has a valid value to prevent an error when querying a timestamp value.
Args:
timestamp_event(nidaqmx.constants.TimestampEvent): Specifies the timestamp type to wait on.
timeout (float): Specifies the maximum amount of time in
seconds to wait for a valid timestamp.
This method returns an error if the time elapses. The
default is 10. If you set timeout (sec) to
nidaqmx.WAIT_INFINITELY, the method waits indefinitely.
"""
self._interpreter.wait_for_valid_timestamp(self._handle, timestamp_event.value, timeout)

def wait_until_done(self, timeout=10.0):
"""
Waits for the measurement or generation to complete.
Expand Down

0 comments on commit 8cac1b8

Please sign in to comment.