Add support for WaitForValidTimestamp to nidaqmx-python #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeborahOoi96
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
DeborahOoi96
force-pushed
the
users/deooi/WaitForValidTimestamp
branch
from
232b41a
to
fd9368f
Compare
bkeryan
requested changes
Jan 31, 2024
DeborahOoi96
force-pushed
the
users/deooi/WaitForValidTimestamp
branch
from
31c1ee0
to
7472d14
Compare
zhindes
approved these changes
Feb 16, 2024
bkeryan
requested changes
Feb 19, 2024
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
maxxboehme
approved these changes
Feb 20, 2024
bkeryan
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds Time Trigger API support for the following functions in nidaqmx-python:
DAQmxWaitForValidTimestamp
Why should this Pull Request be merged?
It provides support for WaitForValidTimestamp in python.
What testing has been done?
Ran nidaqmx-python code generator and validated the API was generated correctly
All existing functional test passed.
Increasing functional test coverage to cover this function will be done in another PR.