-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Angular 15 #1079
Comments
In Angular 15 they reimplemented |
Angular 14 is now in LTS mode till november 2023. Thanks |
@PetitCalgon thanks for your interest! It's always a struggle for us to prioritize this sustaining work but we agree we should upgrade before 14 stops being supported. We'll find a way to get to it eventually but if you happen to have bandwidth on your team to help, we'd be happy to collaborate! |
# Pull Request ## 🤨 Rationale Update to Angular 15.2 for nimble-angular. Resolves #1079 Resolves #1017 Resolves #1570 Resolves #732 Resolves #1665 ## 👩💻 Implementation - Update Angular version to 15.2 using Angular's upgrade utility - Create forks of some of Angular's CVAs and Angular's RouterLink directive under `angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\` with modifications to get them to work as expected as base classes for nimble directives - Add explicit dependency on `source-map-loader` to `nimble-components` to ensure the tests continue to run as they previously did ## 🧪 Testing - Ran the Angular app and verified it worked as expected - Existing unit tests pass - Copied & adapted Angular tests for CVAs and RouterLink directive into `angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\tests\` - Added new unit tests for each nimble CVA that verifies that `ngModelChange` is only called once when a control's value changes - Added new unit tests for each routerLink directive that verifies that the href was sanitized - Used the built package to verify it works correctly in SystemLinkShared ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Mert Akinc <7282195+m-akinc@users.noreply.github.com> Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
🧹 Tech Debt
nimble-angular currently supports Angular 14 but the latest version is 15. We need to support the latest.
This is currently blocked on #810.Once that is fixed we have two options:
@TrevorKarjanis did some research on these options and believes that 2 is possible but he won't have bandwidth to drive progress for a while.
The text was updated successfully, but these errors were encountered: