-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 15 upgrade #1655
Merged
Merged
Angular 15 upgrade #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦nd local copy of RouterLink directive
β¦rs are run twice
β¦o angular-15-upgrade
@m-akinc, can you buddy these changes for me? |
m-akinc
approved these changes
Nov 8, 2023
.../ni/nimble-angular/src/directives/anchor-base/disableable-router-link-with-href.directive.ts
Show resolved
Hide resolved
...lar/src/directives/breadcrumb-item/nimble-breadcrumb-item-router-link-with-href.directive.ts
Show resolved
Hide resolved
...angular/src/directives/number-field/tests/nimble-number-field-control-value-accessor.spec.ts
Outdated
Show resolved
Hide resolved
angular-workspace/projects/ni/nimble-angular/src/thirdparty/utils/coercion.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-components-f628da4e-838f-45bf-9e54-469aa8273f75.json
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Nov 13, 2023
rajsite
reviewed
Nov 15, 2023
...lar-workspace/projects/ni/nimble-angular/src/thirdparty/directives/control_value_accessor.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Nov 15, 2023
rajsite
reviewed
Nov 16, 2023
angular-workspace/projects/ni/nimble-angular/src/thirdparty/directives/router_link.ts
Outdated
Show resolved
Hide resolved
β¦rectives/router_link.ts Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
m-akinc
reviewed
Nov 17, 2023
...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Nov 27, 2023
...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts
Show resolved
Hide resolved
rajsite
reviewed
Nov 27, 2023
angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/browser_util.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Nov 27, 2023
angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/matchers.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Nov 27, 2023
angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/matchers.d.ts
Show resolved
Hide resolved
rajsite
reviewed
Nov 27, 2023
angular-workspace/projects/ni/nimble-angular/src/thirdparty/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Update to Angular 15.2 for nimble-angular.
Resolves #1079
Resolves #1017
Resolves #1570
Resolves #732
Resolves #1665
π©βπ» Implementation
angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\
with modifications to get them to work as expected as base classes for nimble directivessource-map-loader
tonimble-components
to ensure the tests continue to run as they previously didπ§ͺ Testing
angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\tests\
ngModelChange
is only called once when a control's value changesβ Checklist