Card accessibility tweak #1858
Merged
Card accessibility tweak #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
requested review from
jattasNI,
atmgrifter00 and
msmithNI
as code owners
jattasNI
approved these changes
Feb 22, 2024
msmithNI
approved these changes
Feb 22, 2024
atmgrifter00
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The card was previously disabled after it started resulting in axe-core completely failing. After reporting to axe-core their comment in dequelabs/axe-core#4335 (comment) made me think we can workaround the axe-core issue by wrapping the slot in a span and targeting that instead for aria.
While not necessary for runtime behavior or accessibility, the workaround adds minimal overhead and complexity. Does not need to be removed after the axe-core fix. Fixes #1650
👩💻 Implementation
Wraps the slot in a span and use that as the aria target.
🧪 Testing
Can see the PR has a passing lighthouse score with the card re-enabled.
✅ Checklist