New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Abseil btree map and flat hash map support #85
Conversation
I tried fixing the CI process :P libabsl_str_format_internal in abseil is failing to compile but the tests are running successfully as str_format is not linked to the yas_base_tests binary. |
@askamn can you please remove msvc2017 for appveyor tests? also, any ideas how this can be fixed? |
@niXman By removing MSVC 2017 do you mean remove this line: I have no idea how to fix that. |
yes.
ah, got it. thanks! |
So, I managed to fix the travis build also, by building just the tests instead of "all" execs and libs as abseil also adds a few targets to build and by default cmake will build all the targets. So I just specified the I am pretty sure if we add back VS2017 and do the same --target thing to appveyor it will also work fine. Because it was also complaining about the same issue. |
They updated the issue, GCC 4.8 isn't supported as written on the bottom https://abseil.io/docs/cpp/platforms/platforms |
thank you @askamn ! |
@askamn just while trying to build YAS I encountered errors related to the absence of Abseil. |
Added support for abseil containers btree_map and flat_hash_map as requested by @niXman
Please check the CMakeLists.txt, as I added abseil using add_subdirectory(), not sure if that is the right way. Also, you need to do the CI changes yourself.
Also, I have no idea about QT projects, so I did not add the abseil libs to the .pro file.
All tests are passing fine on my local machine.