Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Abseil btree map and flat hash map support #85

Merged
merged 6 commits into from Sep 29, 2020
Merged

Added Abseil btree map and flat hash map support #85

merged 6 commits into from Sep 29, 2020

Conversation

theunwisewolf
Copy link
Contributor

Added support for abseil containers btree_map and flat_hash_map as requested by @niXman

Please check the CMakeLists.txt, as I added abseil using add_subdirectory(), not sure if that is the right way. Also, you need to do the CI changes yourself.

Also, I have no idea about QT projects, so I did not add the abseil libs to the .pro file.

All tests are passing fine on my local machine.

@theunwisewolf
Copy link
Contributor Author

I tried fixing the CI process :P

libabsl_str_format_internal in abseil is failing to compile but the tests are running successfully as str_format is not linked to the yas_base_tests binary.

@niXman
Copy link
Owner

niXman commented Sep 28, 2020

@askamn can you please remove msvc2017 for appveyor tests?

also, any ideas how this can be fixed?

@theunwisewolf
Copy link
Contributor Author

@niXman By removing MSVC 2017 do you mean remove this line: - Visual Studio 2017?

I have no idea how to fix that.
I have opened an issue on abseil's github. Lets see what happens.
abseil/abseil-cpp#795

@niXman
Copy link
Owner

niXman commented Sep 28, 2020

By removing MSVC 2017 do you mean remove this line: - Visual Studio 2017?

yes.

I have no idea how to fix that.
I have opened an issue on abseil's github. Lets see what happens.
abseil/abseil-cpp#795

ah, got it. thanks!

@theunwisewolf
Copy link
Contributor Author

theunwisewolf commented Sep 28, 2020

So, I managed to fix the travis build also, by building just the tests instead of "all" execs and libs as abseil also adds a few targets to build and by default cmake will build all the targets. So I just specified the --target yas-base-tests in the build step to make sure only the tests get build and it worked! Now it's no longer compiling abseil libs that are not used by the project.

I am pretty sure if we add back VS2017 and do the same --target thing to appveyor it will also work fine. Because it was also complaining about the same issue.

@theunwisewolf
Copy link
Contributor Author

They updated the issue, GCC 4.8 isn't supported as written on the bottom https://abseil.io/docs/cpp/platforms/platforms

@niXman
Copy link
Owner

niXman commented Sep 29, 2020

thank you @askamn !

@niXman niXman merged commit 91ae019 into niXman:master Sep 29, 2020
@niXman
Copy link
Owner

niXman commented Oct 16, 2020

@askamn

just while trying to build YAS I encountered errors related to the absence of Abseil.
this should not be the case, the user is not obliged to install Abseil if he does not plan to use it.
please fix it as soon as possible.

@niXman niXman mentioned this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants