Build failing with GCC 4.8.4 Ubuntu

[theunwisewolf]

Describe the bug

marshalling.cc fails to compile with the following error:

[ 71%] Building CXX object build/abseil/absl/flags/CMakeFiles/absl_flags_marshalling.dir/marshalling.cc.o
/usr/local/abseil-cpp/absl/flags/marshalling.cc: In instantiation of ‘std::string absl::flags_internal::UnparseFloatingPointVal(T) [with T = float; std::string = std::basic_string<char>]’:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:193:64:   required from here
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: error: no matching function for call to ‘StrFormat(const char [5], const int&, float&)’
       absl::StrFormat("%.*g", std::numeric_limits<T>::digits10, v);
                                                                  ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: note: candidate is:
In file included from /usr/local/abseil-cpp/absl/flags/marshalling.cc:33:0:
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note: template<class ... Args> std::string absl::StrFormat(absl::FormatSpec<Args ...>&, const Args& ...)
 ABSL_MUST_USE_RESULT std::string StrFormat(const FormatSpec<Args...>& format,
                                  ^
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note:   template argument deduction/substitution failed:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: note:   mismatched types ‘absl::FormatSpec<Args ...>’ and ‘const char [5]’
       absl::StrFormat("%.*g", std::numeric_limits<T>::digits10, v);
                                                                  ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: error: no matching function for call to ‘StrFormat(const char [5], const int&, float&)’
   return absl::StrFormat("%.*g", std::numeric_limits<T>::max_digits10, v);
                                                                         ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: note: candidate is:
In file included from /usr/local/abseil-cpp/absl/flags/marshalling.cc:33:0:
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note: template<class ... Args> std::string absl::StrFormat(absl::FormatSpec<Args ...>&, const Args& ...)
 ABSL_MUST_USE_RESULT std::string StrFormat(const FormatSpec<Args...>& format,
                                  ^
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note:   template argument deduction/substitution failed:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: note:   mismatched types ‘absl::FormatSpec<Args ...>’ and ‘const char [5]’
   return absl::StrFormat("%.*g", std::numeric_limits<T>::max_digits10, v);
                                                                         ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc: In instantiation of ‘std::string absl::flags_internal::UnparseFloatingPointVal(T) [with T = double; std::string = std::basic_string<char>]’:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:194:65:   required from here
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: error: no matching function for call to ‘StrFormat(const char [5], const int&, double&)’
       absl::StrFormat("%.*g", std::numeric_limits<T>::digits10, v);
                                                                  ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: note: candidate is:
In file included from /usr/local/abseil-cpp/absl/flags/marshalling.cc:33:0:
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note: template<class ... Args> std::string absl::StrFormat(absl::FormatSpec<Args ...>&, const Args& ...)
 ABSL_MUST_USE_RESULT std::string StrFormat(const FormatSpec<Args...>& format,
                                  ^
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note:   template argument deduction/substitution failed:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:179:66: note:   mismatched types ‘absl::FormatSpec<Args ...>’ and ‘const char [5]’
       absl::StrFormat("%.*g", std::numeric_limits<T>::digits10, v);
                                                                  ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: error: no matching function for call to ‘StrFormat(const char [5], const int&, double&)’
   return absl::StrFormat("%.*g", std::numeric_limits<T>::max_digits10, v);
                                                                         ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: note: candidate is:
In file included from /usr/local/abseil-cpp/absl/flags/marshalling.cc:33:0:
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note: template<class ... Args> std::string absl::StrFormat(absl::FormatSpec<Args ...>&, const Args& ...)
 ABSL_MUST_USE_RESULT std::string StrFormat(const FormatSpec<Args...>& format,
                                  ^
/usr/local/abseil-cpp/absl/strings/str_format.h:338:34: note:   template argument deduction/substitution failed:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:191:73: note:   mismatched types ‘absl::FormatSpec<Args ...>’ and ‘const char [5]’
   return absl::StrFormat("%.*g", std::numeric_limits<T>::max_digits10, v);
                                                                         ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc: In function ‘std::string absl::flags_internal::UnparseFloatingPointVal(T) [with T = float; std::string = std::basic_string<char>]’:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:192:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
/usr/local/abseil-cpp/absl/flags/marshalling.cc: In function ‘std::string absl::flags_internal::UnparseFloatingPointVal(T) [with T = double; std::string = std::basic_string<char>]’:
/usr/local/abseil-cpp/absl/flags/marshalling.cc:192:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[2]: *** [build/abseil/absl/flags/CMakeFiles/absl_flags_marshalling.dir/marshalling.cc.o] Error 1
make[1]: *** [build/abseil/absl/flags/CMakeFiles/absl_flags_marshalling.dir/all] Error 2
make: *** [all] Error 2
The command "cmake --build . --config Release" exited with 2.

Steps to reproduce the bug

Just compile abseil using GCC 4.8.2

What version of Abseil are you using?

Each of my builds use the lastest clone from github.

What operating system and version are you using

Ubuntu 14.04.5 LTS

What compiler and version are you using?

gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4

What build system are you using?

cmake version 3.9.2

Additional context

I am building an app that uses abseil using travis CI.
The same abseil clone compiles fine with Clang on the same system.

[derekmauro]

https://abseil.io/docs/cpp/platforms/platforms: GCC 4.8 isn't supported.