fix node failure on command error

niallo · Nov 1, 2013 · 587271e · 587271e
1 parent 7d1f3bd
commit 587271e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -150,6 +150,10 @@ function run(baseDir, privKey, cmd, keyMode, cb) {
         }
         self(err, proc.stdoutBuffer, proc.stderrBuffer, exitCode)
       })
+      proc.on('error', function (err) {
+        // prevent node from throwing an error. The error handling is
+        // done in the 'close' handler.
+      })
     },
     function(err, stdout, stderr, exitCode) {
       // cleanup temp files

diff --git a/test/test.js b/test/test.js
@@ -27,6 +27,14 @@ describe('gitane', function() {
       })
     })
 
+    it('should correctly handle failed commands', function (done) {
+      gitane.run(os.tmpDir(), 'testkey', 'notarealcommand', function (err, stdout, stderr, exitCode) {
+        expect(err).to.be.ok
+        expect(exitCode).to.be.ok
+        done()
+      })
+    })
+
   }),
 
   describe('#writeFiles', function() {