Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communications down bug #12

Closed
nibuen opened this issue Aug 19, 2014 · 8 comments
Closed

Communications down bug #12

nibuen opened this issue Aug 19, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@nibuen
Copy link
Owner

nibuen commented Aug 19, 2014

Communications down bug All missions after the first run through don't properly play the static sound. It does one static burst then remains silent for the entire duration of comms down.

Phone: Motorola RAZR M (smq)

@nibuen nibuen added the bug label Aug 19, 2014
@nibuen
Copy link
Owner Author

nibuen commented Aug 19, 2014

This was reported today. I have tried reproducing on emulator and device with no luck so far.

@tompen
Copy link
Collaborator

tompen commented Aug 19, 2014

Did you get the exakt steps to reproduce the problem? Do the problem occur on all missions after exactly one mission has been played?
Which android version was the submittor using?

The mediaplayer does print out warnings in the log. This might indicate a problem that causes a problem on some devices:

08-19 22:39:14.926  24694-24694/com.boarbeard E/MediaPlayer-JNI﹕ QCMediaPlayer mediaplayer NOT present
08-19 22:39:15.056  24694-24694/com.boarbeard E/MediaPlayer﹕ Should have subtitle controller already set
08-19 22:39:21.896  24694-24694/com.boarbeard E/MediaPlayer-JNI﹕ QCMediaPlayer mediaplayer NOT present
08-19 22:39:21.986  24694-24694/com.boarbeard W/MediaPlayer﹕ mediaplayer went away with unhandled events
08-19 22:39:21.986  24694-24694/com.boarbeard E/MediaPlayer﹕ Should have subtitle controller already set
08-19 22:39:28.286  24694-24694/com.boarbeard E/MediaPlayer-JNI﹕ QCMediaPlayer mediaplayer NOT present
08-19 22:39:28.316  24694-24694/com.boarbeard W/MediaPlayer﹕ mediaplayer went away with unhandled events
 

@nibuen
Copy link
Owner Author

nibuen commented Aug 19, 2014

That looks to be related to issue #13

I don't think has any effect on playing though.

I don't get version as part of comment so can't tell, but could infer from phone type listed above. I am asking for steps/details and will report here if hear back.

P.S. to be clear the defect above comes verbatim from the issue submitted on comment.

@tompen
Copy link
Collaborator

tompen commented Aug 20, 2014

The file for white noise is an ogg-file. All other audio files are mp3:s. I
think the problem will probably go away if we convert the file to mp3.

On 19 August 2014 22:57, Leif Norcott notifications@github.com wrote:

That looks to be related to issue #13
#13

I don't think has any effect like so. I don't get version as part of
comment so can't tell, but could infer from phone type listed above. I am
asking for steps/details and will report here if hear back.


Reply to this email directly or view it on GitHub
#12 (comment)
.

nibuen added a commit that referenced this issue Aug 20, 2014
Changed white noise to mp3 in attempt to fix issue #12
@tompen
Copy link
Collaborator

tompen commented Aug 21, 2014

Related question. Is there a reason why the german language pack is not
included in the main application? The german language pack could be added
to the folder "master/app/src/main/res/raw-de". It would then be
automaticly selected on german devices.

German language pack:
https://code.google.com/p/space-alert-mission-generator-android-lang/source/browse/#svn%2Fbranches%2Fde%2Fres%2Fraw

On 20 August 2014 11:29, Torbjörn Eklund torbjorn.eklund@gmail.com wrote:

The file for white noise is an ogg-file. All other audio files are mp3:s.
I think the problem will probably go away if we convert the file to mp3.

On 19 August 2014 22:57, Leif Norcott notifications@github.com wrote:

That looks to be related to issue #13
#13

I don't think has any effect like so. I don't get version as part of
comment so can't tell, but could infer from phone type listed above. I am
asking for steps/details and will report here if hear back.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@nibuen
Copy link
Owner Author

nibuen commented Aug 21, 2014

Hmm I think it was decided just to keep size down, but seems like that is done for us by android if we go this route?

Please use issue: #14

@tompen
Copy link
Collaborator

tompen commented Aug 21, 2014

Thats a good point. The file size would defintely increase.
Den 21 aug 2014 17:30 skrev "Leif Norcott" notifications@github.com:

Hmm I think it was decided just to keep size down, but seems like that is
done for us by android if we go this route?


Reply to this email directly or view it on GitHub
#12 (comment)
.

@nibuen
Copy link
Owner Author

nibuen commented Nov 24, 2014

I'm gonna use this to fix the gap that now happens in Android 5.0 with communication down loop (most likely going to SoundPool). Then will see if gets reported again.

@nibuen nibuen self-assigned this Nov 24, 2014
@nibuen nibuen added this to the 3.1.0 milestone Nov 24, 2014
nibuen added a commit that referenced this issue Dec 15, 2014
Tried a couple different things and nothing seems to get rid of the gap
on Nexus 4 correctly.  So instead just went to a 20 second communication
down file.
@nibuen nibuen closed this as completed Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants