Implement rounded rectangle stroke #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
reviewed
Jul 7, 2017
tessellation/src/basic_shapes.rs
Outdated
| let p4 = point(x_max, y_max - br); | ||
|
|
||
| let sides = &[ | ||
| [p1, p2], |
There was a problem hiding this comment.
nit: let's indent this one extra level.
tessellation/src/basic_shapes.rs
Outdated
| &mut builder, | ||
| ); | ||
| for i in 1..4 { | ||
| builder.line_to(sides[i][0]); |
There was a problem hiding this comment.
Isn't the end of the previous iteration already going to finish at this position? If we can make it so, then you could even move the line_to and the stroke_border_radius_build above into the loop (and just have the move_to outside the loop).
|
moved the first |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.
The problem with the #82 was the segmentation of the shape, which could result in a mismatch between the different parts. This is addressed by producing one continuous shape, and by finding only the inner points in rounded borders (since the outer ones could be part of other paths).