GW-38 Move author to metadata

Move card metadata into the list of metadata as this is semantically correct, rather than just being a div within the article
nice-digital · Feb 2, 2018 · b161108 · b161108
1 parent a769d6c
commit b161108
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/src/components/card/_card.scss b/src/components/card/_card.scss
@@ -63,6 +63,11 @@
     @include font-size(-1);
     color: $colour-nice-dark-grey;
     margin: rem(0 0 $spacing-x-small 0);
+
+    dd {
+      display: block;
+      margin: 0;
+    }
   }
 
   &__summary {

diff --git a/src/components/card/card.njk b/src/components/card/card.njk
@@ -17,14 +17,14 @@
 			{{ card.summary }}
 		</p>
 	{% endif %}
-	{% if card.author %}
-		<div class="card__author">
-			<span class="visually-hidden">Written by: </span>
-			{{ card.author }}
-		</div>
-	{% endif %}
-	{% if card.metadata %}
+	{% if card.metadata or card.author %}
 		<dl class="card__metadata">
+			{% if card.author %}
+				<div class="card__author">
+					<dt class="visually-hidden">Written by: </dt>
+					<dd>{{ card.author }}</dd>
+				</div>
+			{% endif %}
 			{% if card.tag %}
 				<div class="card__metadatum">
 					<dt>