NDS-36 Added teamcity reporter for test:coverage #22
Conversation
d-lan1
force-pushed
the
NDS36-teamcity
branch
from
ea8044d
to
949a9b3
Compare
ediblecode
changed the title
package.json
Outdated
| @@ -61,6 +66,7 @@ | |||
| "chalk": "^2.3.0", | |||
| "compression": "^1.6.2", | |||
| "debug": "^3.1.0", | |||
| "each-async": "^1.0.0", | |||
There was a problem hiding this comment.
Not sure we need each-async as an explicit dependency.
There was a problem hiding this comment.
Hey i was having issues with it locally for some reason. I think i may have caused it while experimenting with eslint teamcity reporter but not 100% it was caused this way. I will remove it from being explicitly required.
package.json
Outdated
| @@ -102,6 +108,7 @@ | |||
| "pixrem": "^4.0.1", | |||
| "postcss-banner": "^3.0.0", | |||
| "serve-favicon": "^2.4.2", | |||
| "sigmund": "^1.0.1", | |||
There was a problem hiding this comment.
Not sure we need sigmund as an explicit dependency.
There was a problem hiding this comment.
same as for each-async
package.json
Outdated
| "// JAVASCRIPT": "", | ||
| "webpack": "SET \"NODE_ENV=production\" && webpack --progress --colors --display-error-details", | ||
| "// TESTS": "", | ||
| "test": "mocha src/**/*.test.js test/**/*.test.js --require babel-core/register --require mocha-clean --require test/_setup.js --color", | ||
| "test:teamcity": "mocha --reporter mocha-teamcity-reporter src/**/*.test.js test/**/*.test.js --require babel-core/register --require mocha-clean --require test/_setup.js --color", |
There was a problem hiding this comment.
We've got a moch grunt task for this so we should move these mocha build targets into there instead
package.json
Outdated
| @@ -22,12 +22,17 @@ | |||
| "scripts": { | |||
| "start": "grunt --color --timing", | |||
| "dist": "grunt dist --color", | |||
| "prebuild": "grunt prebuild:dist --color", | |||
| "build": "grunt build:dist --color", | |||
| "dist:teamcity": "npm run lint && npm run test:coverage:teamcity && grunt css:dist --color && grunt docs --color && grunt webpack", | |||
There was a problem hiding this comment.
This dist:teamcity command isn't being used so we should remove it. And also, we have grunt as a task runner for aliasing tasks so we can chain commands in gruntfile rather than here to keep this simpler
# Conflicts: # package-lock.json # package.json
https://nicedigital.atlassian.net/browse/NDS-36