NDS-69 Fix accessibility style issues for guidance web topic page #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-lan1
previously approved these changes
May 8, 2019
ediblecode
changed the title
ediblecode
previously approved these changes
May 13, 2019
ediblecode
previously approved these changes
May 14, 2019
|
I have updated the style to remove the padding from the fieldset as it is no longer needed with new structure for FilterGroup component in Guidance Web |
ediblecode
suggested changes
May 17, 2019
There was a problem hiding this comment.
@colinmazu can you update filter-group.njk with the new structure and test the new styling doesn't break the old markup (ie we don't have a breaking change)
|
Changed Nunchuck template file as requested. - looks fine with no breaking changes |
ediblecode
previously approved these changes
May 21, 2019
ediblecode
approved these changes
May 28, 2019
ediblecode
deleted the
NDS-69-Fix-accessibility-style-issues-for-Guidance-Web-Topic-Page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/NDS-69
See also https://github.com/nhsevidence/guidance-web/pull/177