Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NDS-69 Fix accessibility style issues for guidance web topic page #45

Merged
merged 11 commits into from
May 30, 2019
Merged

NDS-69 Fix accessibility style issues for guidance web topic page #45

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
895c8b9
NDS-69 fixed sytle issues with fieldset and legend
Apr 29, 2019
1c55871
NDS-69 Added padding to fieldset overide default
May 7, 2019
6125250
NDS-69 Fixed issues with fieldset and legend style
May 8, 2019
d570dfd
Release v0.5.4
May 10, 2019
5151be9
Release v0.5.5
May 10, 2019
7804687
Release v0.5.6
May 13, 2019
a3aea40
NDS-69 Updated fieldset style to resolve axe issue
May 13, 2019
a56be15
Release v0.5.7
May 13, 2019
573d705
NDS-69 Fixed issues with FilterGroup styles
May 15, 2019
5051598
NDS-69 Update nun chuck template filter-group
May 21, 2019
9b745f0
Release v0.5.8
May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dist/docs/js/nice-design-system.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"column": 2
}
},
"file": "C:\\Users\\iroutledge\\Documents\\Dev\\@nice-digital\\nice-design-system\\src\\javascripts\\breakpoints.js"
"file": "C:\\src\\nice-design-system\\src\\javascripts\\breakpoints.js"
},
"augments": [],
"examples": [],
Expand Down Expand Up @@ -77,7 +77,7 @@
"end": {
"line": 3,
"column": 46,
"offset": 134
"offset": 136
},
"indent": [
1,
Expand All @@ -95,7 +95,7 @@
"end": {
"line": 3,
"column": 46,
"offset": 134
"offset": 136
},
"indent": [
1,
Expand All @@ -113,7 +113,7 @@
"end": {
"line": 3,
"column": 46,
"offset": 134
"offset": 136
}
}
},
Expand All @@ -139,7 +139,7 @@
"column": 2
}
},
"file": "C:\\Users\\iroutledge\\Documents\\Dev\\@nice-digital\\nice-design-system\\src\\javascripts\\breakpoints.js"
"file": "C:\\src\\nice-design-system\\src\\javascripts\\breakpoints.js"
},
"augments": [],
"examples": [],
Expand Down Expand Up @@ -241,7 +241,7 @@
},
{
"title": "example",
"description": "import { matchesFrom } from \"./breakpoints\";\n\t// Checks if the media query (min-width: 25em) matches\n\tvar matches = matchesFrom(\"xs\");",
"description": "import { matchesFrom } from \"./breakpoints\";\r\n\t// Checks if the media query (min-width: 25em) matches\r\n\tvar matches = matchesFrom(\"xs\");",
"lineNumber": 6
}
],
Expand All @@ -266,12 +266,12 @@
"column": 2
}
},
"file": "C:\\Users\\iroutledge\\Documents\\Dev\\@nice-digital\\nice-design-system\\src\\javascripts\\breakpoints.js"
"file": "C:\\src\\nice-design-system\\src\\javascripts\\breakpoints.js"
},
"augments": [],
"examples": [
{
"description": "import { matchesFrom } from \"./breakpoints\";\n\t// Checks if the media query (min-width: 25em) matches\n\tvar matches = matchesFrom(\"xs\");"
"description": "import { matchesFrom } from \"./breakpoints\";\r\n\t// Checks if the media query (min-width: 25em) matches\r\n\tvar matches = matchesFrom(\"xs\");"
}
],
"params": [
Expand Down
8 changes: 4 additions & 4 deletions dist/docs/sass/nice-design-system.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2963,10 +2963,10 @@
"context": {
"type": "css",
"name": ".filter-group",
"value": "margin-top: rem($spacing-medium);\n\n &:first-child {\n margin-top: 0;\n }\n\n // Heading used for collapsing/expanding the filter group\n &__heading {\n @include font-size(0);\n background: $colour-nice-grey-2;\n border: 0;\n display: block;\n font-weight: bold;\n margin: 0;\n padding: rem($spacing-small);\n position: relative;\n text-align: left;\n width: 100%;\n\n @include when-is(button) {\n appearance: none;\n cursor: pointer;\n\n &:after {\n @include nice-icon(chevron-up);\n @include font-size(-1);\n color: $colour-icons;\n line-height: normal; // IE 9/10 bug where rems on block psuedos collapse to 0\n position: absolute;\n right: rem($spacing-small);\n top: rem($spacing-small);\n }\n\n &[aria-expanded='false']:after {\n content: nice-icon(chevron-down);\n }\n\n &:hover {\n background: $colour-nice-grey-1;\n\n // sass-lint:disable no-combinators\n + .filter-group__options {\n border-color: $colour-nice-grey-1;\n }\n }\n\n &:focus {\n @include default-focus-style;\n }\n }\n }\n\n // Shows the number of filtered options e.g. \"2 selected\"\n &__count {\n @include font-size(-1);\n font-weight: normal;\n }\n\n // Wrapper for the options when filter is a list of checboxes\n &__options {\n border: rem($spacing-x-small) solid $colour-nice-grey-2;\n\n &[aria-hidden='true'] {\n display: none;\n }\n }\n\n // Checkbox/radio button option (label)\n &__option {\n background: $colour-nice-white;\n border-top: 1px solid $colour-nice-grey-2;\n cursor: pointer;\n display: block;\n line-height: 1.2;\n padding: rem($spacing-small $spacing-small $spacing-small $spacing-large);\n\n &:first-child {\n border-top: 0;\n }\n\n &:hover {\n background: $colour-nice-grey-3;\n }\n\n input {\n float: left;\n height: rem($spacing-medium);\n margin-left: - rem($spacing-medium + $spacing-small);\n margin-top: rem($spacing-xx-small);\n width: rem($spacing-medium);\n\n &:focus {\n @include default-focus-style;\n }\n }\n }",
"value": "margin-top: rem($spacing-medium);\n\n legend {\n @include invisible();\n }\n\n fieldset {\n border: 0;\n margin: 0;\n padding: 0;\n }\n\n &:first-child {\n margin-top: 0;\n }\n\n // Heading used for collapsing/expanding the filter group\n &__heading {\n @include font-size(0);\n background: $colour-nice-grey-2;\n border: 0;\n display: block;\n font-weight: bold;\n margin: 0;\n padding: rem($spacing-small);\n position: relative;\n text-align: left;\n width: 100%;\n\n @include when-is(button) {\n appearance: none;\n cursor: pointer;\n\n &:after {\n @include nice-icon(chevron-up);\n @include font-size(-1);\n color: $colour-icons;\n line-height: normal; // IE 9/10 bug where rems on block psuedos collapse to 0\n position: absolute;\n right: rem($spacing-small);\n top: rem($spacing-small);\n }\n\n &[aria-expanded='false']:after {\n content: nice-icon(chevron-down);\n }\n\n &:hover {\n background: $colour-nice-grey-1;\n\n // sass-lint:disable no-combinators\n + .filter-group__options {\n border-color: $colour-nice-grey-1;\n }\n }\n\n &:focus {\n @include default-focus-style;\n }\n }\n }\n\n // Shows the number of filtered options e.g. \"2 selected\"\n &__count {\n @include font-size(-1);\n font-weight: normal;\n }\n\n // Wrapper for the options when filter is a list of checboxes\n &__options {\n border: rem($spacing-x-small) solid $colour-nice-grey-2;\n &[aria-hidden='true'] {\n display: none;\n }\n }\n\n // Checkbox/radio button option (label)\n &__option {\n background: $colour-nice-white;\n border-top: 1px solid $colour-nice-grey-2;\n cursor: pointer;\n display: block;\n line-height: 1.2;\n padding: rem($spacing-small $spacing-small $spacing-small $spacing-large);\n\n &:first-child {\n border-top: 0;\n }\n\n &:hover {\n background: $colour-nice-grey-3;\n }\n\n input {\n float: left;\n height: rem($spacing-medium);\n margin-left: - rem($spacing-medium + $spacing-small);\n margin-top: rem($spacing-xx-small);\n width: rem($spacing-medium);\n\n &:focus {\n @include default-focus-style;\n }\n }\n }",
"line": {
"start": 10,
"end": 108
"end": 117
}
},
"since": [
Expand Down Expand Up @@ -12726,10 +12726,10 @@
"context": {
"type": "css",
"name": ".filter-group",
"value": "margin-top: rem($spacing-medium);\n\n &:first-child {\n margin-top: 0;\n }\n\n // Heading used for collapsing/expanding the filter group\n &__heading {\n @include font-size(0);\n background: $colour-nice-grey-2;\n border: 0;\n display: block;\n font-weight: bold;\n margin: 0;\n padding: rem($spacing-small);\n position: relative;\n text-align: left;\n width: 100%;\n\n @include when-is(button) {\n appearance: none;\n cursor: pointer;\n\n &:after {\n @include nice-icon(chevron-up);\n @include font-size(-1);\n color: $colour-icons;\n line-height: normal; // IE 9/10 bug where rems on block psuedos collapse to 0\n position: absolute;\n right: rem($spacing-small);\n top: rem($spacing-small);\n }\n\n &[aria-expanded='false']:after {\n content: nice-icon(chevron-down);\n }\n\n &:hover {\n background: $colour-nice-grey-1;\n\n // sass-lint:disable no-combinators\n + .filter-group__options {\n border-color: $colour-nice-grey-1;\n }\n }\n\n &:focus {\n @include default-focus-style;\n }\n }\n }\n\n // Shows the number of filtered options e.g. \"2 selected\"\n &__count {\n @include font-size(-1);\n font-weight: normal;\n }\n\n // Wrapper for the options when filter is a list of checboxes\n &__options {\n border: rem($spacing-x-small) solid $colour-nice-grey-2;\n\n &[aria-hidden='true'] {\n display: none;\n }\n }\n\n // Checkbox/radio button option (label)\n &__option {\n background: $colour-nice-white;\n border-top: 1px solid $colour-nice-grey-2;\n cursor: pointer;\n display: block;\n line-height: 1.2;\n padding: rem($spacing-small $spacing-small $spacing-small $spacing-large);\n\n &:first-child {\n border-top: 0;\n }\n\n &:hover {\n background: $colour-nice-grey-3;\n }\n\n input {\n float: left;\n height: rem($spacing-medium);\n margin-left: - rem($spacing-medium + $spacing-small);\n margin-top: rem($spacing-xx-small);\n width: rem($spacing-medium);\n\n &:focus {\n @include default-focus-style;\n }\n }\n }",
"value": "margin-top: rem($spacing-medium);\n\n legend {\n @include invisible();\n }\n\n fieldset {\n border: 0;\n margin: 0;\n padding: 0;\n }\n\n &:first-child {\n margin-top: 0;\n }\n\n // Heading used for collapsing/expanding the filter group\n &__heading {\n @include font-size(0);\n background: $colour-nice-grey-2;\n border: 0;\n display: block;\n font-weight: bold;\n margin: 0;\n padding: rem($spacing-small);\n position: relative;\n text-align: left;\n width: 100%;\n\n @include when-is(button) {\n appearance: none;\n cursor: pointer;\n\n &:after {\n @include nice-icon(chevron-up);\n @include font-size(-1);\n color: $colour-icons;\n line-height: normal; // IE 9/10 bug where rems on block psuedos collapse to 0\n position: absolute;\n right: rem($spacing-small);\n top: rem($spacing-small);\n }\n\n &[aria-expanded='false']:after {\n content: nice-icon(chevron-down);\n }\n\n &:hover {\n background: $colour-nice-grey-1;\n\n // sass-lint:disable no-combinators\n + .filter-group__options {\n border-color: $colour-nice-grey-1;\n }\n }\n\n &:focus {\n @include default-focus-style;\n }\n }\n }\n\n // Shows the number of filtered options e.g. \"2 selected\"\n &__count {\n @include font-size(-1);\n font-weight: normal;\n }\n\n // Wrapper for the options when filter is a list of checboxes\n &__options {\n border: rem($spacing-x-small) solid $colour-nice-grey-2;\n &[aria-hidden='true'] {\n display: none;\n }\n }\n\n // Checkbox/radio button option (label)\n &__option {\n background: $colour-nice-white;\n border-top: 1px solid $colour-nice-grey-2;\n cursor: pointer;\n display: block;\n line-height: 1.2;\n padding: rem($spacing-small $spacing-small $spacing-small $spacing-large);\n\n &:first-child {\n border-top: 0;\n }\n\n &:hover {\n background: $colour-nice-grey-3;\n }\n\n input {\n float: left;\n height: rem($spacing-medium);\n margin-left: - rem($spacing-medium + $spacing-small);\n margin-top: rem($spacing-xx-small);\n width: rem($spacing-medium);\n\n &:focus {\n @include default-focus-style;\n }\n }\n }",
"line": {
"start": 10,
"end": 108
"end": 117
}
},
"since": [
Expand Down
4 changes: 2 additions & 2 deletions dist/javascripts/modernizr.nice.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/javascripts/nice.dev.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/javascripts/nice.dev.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/javascripts/nice.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 14 additions & 4 deletions dist/stylesheets/nice.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/stylesheets/nice.css.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/stylesheets/nice.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stylesheets/nice.min.css.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading