Implement stable ABI builds #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the Python side has no way to access them, since apparently
transitive non-module dependencies are not accessible from bzlmod.
Means that flags are henceforth available as `@nanobind_bazel//:$FLAG`,
e.g. `@nanobind_bazel//:minsize`.
Adds a `--py-limited-api` flag that controls the SABI build target version.
Currently only cp3{12,13} are supported, because that's what nanobind
supports, but it might be possible to open this up if the limited API
version and the Python interpreter build version can be different.
Basically only supplies a single define per branch, or nothing if the falseish option is given. This is supposedly solvable more elegantly with transitions, but I have not read up enough on it yet to apply it for this case.
|
@wjakob Could you explain why only CPython>=3.12 is supported for nanobind SABI builds? The oldest Python ABI selectable is 3.2 (with |
|
Because nanobind depends on functionality that hasn't become part of the SABI until 3.12. |
Also add more required config settings for stable ABI + unix (producing a .abi3.so extension).
nicholasjng
force-pushed
the
stable-abi-builds
branch
from
2860006
to
5bc9ecf
Compare
|
Summary:
I'm going to merge this for now, and restructure the settings into a helper later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in progress, the extension name is not correct yet (needs to be
.abi3.soin the SABI case).However, I'm not sure how this is solvable elegantly outside of a completely custom rule implementation for
nanobind_extension.Usage:
Currently only
cp312andcp313are supported as targetable Python ABI versions.