Duplicate search results

[erikandersen]

If I enter a search term and the file is modified while glogg is searching, glogg starts the search from the beginning and the search results appear in duplicate.

Note the repeating line numbers after 255157

[gin-ahirsch]

Do you get this with a build from master? This might have gotten fixed via 9f85093.

[erikandersen]

I use glogg v1.1.4-x68_64 /Erik Från: gin-ahirsch <notifications@github.com> Skickat: den 20 november 2018 17:00 Till: nickbnf/glogg <glogg@noreply.github.com> Kopia: Erik Andersén <erik.andersen@liu.se>; Author <author@noreply.github.com> Ämne: Re: [nickbnf/glogg] Duplicate search results (#247) Do you get this with a build from master? This might have gotten fixed via 9f85093<9f85093>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#247 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGjfKA6HXdgtRHCgEocM0QbyasqyhdUSks5uxCbxgaJpZM4YpQD8>.

[gin-ahirsch]

That does not include the mentioned commit.
You will either have to build yourself or wait for #243 or #189, though the project seems to be rather inactive at the moment.

You could try an appveyor build artifact from @variar's fork https://github.com/variar/klogg, though I'm uncertain if it has already merged the fix: https://ci.appveyor.com/project/variar/klogg.

[ghost]

@variar's fork does not include this commit. Also, his fork hasn't seen any activity since around the same time that this one has.

[variar]

One of the reasons to start my own fork was to be able to make changes faster. Now after several years I understand why Nicolas doesn't react to issues and pull requests very fast.

Last night I've found a way to make initial indexing io-bound (and it becomes two times faster on my machine with clean fs cache, hint: memchr). Also it's time to rebuild klogg binaries with updated Qt version. So I'm going to look into current issues, try to resolve easy or very annoying ones and make a new release in February.

[variar]

I've merged @gin-ahirsch commits to klogg (CI builds 19.01.0.273, links to binaries for different platforms are on main repo page).

Also I've updated #189 so latest master build artifacts for windows can be downloaded from https://ci.appveyor.com/project/nickbnf/glogg/builds/21795819/artifacts

Could you check if either of these builds works for you?

[kpkpkp]

I am seeing the same - I think it may be related to viewing very large files

[variar]

I've investigated and fixed somewhat similar issue in variar#68 . In my case some completely unrelated lines appeared in search results. One possible cause for this issue could be not detecting that file has been changed in already indexed part. That way index gets messed up.