Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Filters" to "Highlighters" #71

Open
sschuberth opened this issue Sep 1, 2014 · 2 comments
Open

Rename "Filters" to "Highlighters" #71

sschuberth opened this issue Sep 1, 2014 · 2 comments
Assignees
@nickbnf
Milestone
1.1.0

Comments

@sschuberth
Copy link

sschuberth commented Sep 1, 2014 •
edited
Loading

IMHO, the term "Filters" is very misleading here as

  • what's currently named "Filters" does not filter anything,
  • and "Filters" better applies to the filtered view below the "Search" field.
@sschuberth sschuberth mentioned this issue Sep 1, 2014
Open
@nickbnf
Copy link
Owner

nickbnf commented Sep 18, 2014

You're absolutely right, will do!

@nickbnf nickbnf self-assigned this Sep 18, 2014
@nickbnf nickbnf added this to the 1.1.0 milestone Dec 15, 2014
arthurspa added a commit to arthurspa/glogg that referenced this issue May 21, 2018
@arthurspa
Renaming "Filters" to "Highlighters" nickbnf#71
9892967
@arthurspa arthurspa mentioned this issue May 21, 2018
Open
@arthurspa
Copy link

I refactored it in PR #216.

gin-ahirsch pushed a commit to gin-ahirsch/glogg that referenced this issue Jun 27, 2019
@variar
Merge pull request nickbnf#71 from gin-ahirsch/empty-keyevent-text-klogg
294d224 
Prevent potential out-of-bounds access in AbstractLogView::keyPressEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickbnf nickbnf

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@nickbnf @sschuberth @arthurspa