Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for NN_SOCKET_NAME #67

Closed
nickdesaulniers opened this issue Mar 16, 2015 · 5 comments
Closed

drop support for NN_SOCKET_NAME #67

nickdesaulniers opened this issue Mar 16, 2015 · 5 comments

Comments

@nickdesaulniers
Copy link
Owner

Our code for handling getting the socket name is ridiculous. I'm going to rip out support for this functionality, since its basis is marked as experimental:

https://github.com/nanomsg/nanomsg/blob/a6dcc0ce7cf489e957e6f07ca756ac66f2420b36/doc/nn_getsockopt.txt#L107-L110
http://nanomsg.org/v0.5/nn_env.7.html

@blowback , the code has your name on it. Will you be affected?

@nickdesaulniers
Copy link
Owner Author

Also: https://github.com/nickdesaulniers/node-nanomsg/blob/master/src/node_nanomsg.cc#L151-L158 and everywhere else NN_SOCKET_NAME is.

@reqshark
Copy link
Collaborator

I'm rewriting some of this right now in #65

@blowback
Copy link
Contributor

Go for it!

On 16 March 2015 at 21:05, Bent Cardan notifications@github.com wrote:

I'm rewriting some of this right now in #65
#65


Reply to this email directly or view it on GitHub
#67 (comment)
.

@reqshark
Copy link
Collaborator

@blowback ok cool thanks!

@nickdesaulniers
Copy link
Owner Author

Fixed in PR: #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants