Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex to fit for non-recursive make. #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lyonlh
Copy link
Contributor

@lyonlh lyonlh commented Dec 7, 2019

Fix the issue #90

Comment on lines +35 to +36
make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])*: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")
make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])*: Leaving directory .*$")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to allow at most one bracket pair:

Suggested change
make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])*: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")
make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])*: Leaving directory .*$")
make_enter_dir = re.compile(r"^\s*make(?:\[\d+\])?: Entering directory [`\'\"](?P<dir>.*)[`\'\"]\s*$")
make_leave_dir = re.compile(r"^\s*make(?:\[\d+\])?: Leaving directory .*$")

@i-ky
Copy link

i-ky commented Jun 29, 2022

@nickdiego, could you please merge and release this fix, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants