chore(*): Upgrade to hyper-0.14.x #459

jolhoeft · 2020-08-24T07:32:08Z

At long last, we have an async version. This PR builds, and all but one example program works and have been tested (except the long broken https example). This is complete enough that the remaining work can be broken into more manageable pieces. There are some limitations:

cargo test fails horribly. This PR is already large, and the integration tests require rewriting the test harness, so I plan on fixing the tests in the next PR. I could be persuaded otherwise though.

The following are all for a future PR.

async functions don't yet have a default Middleware implementation. This should be mostly a case of figuring out the correct type signature.
middleware and router macros do not support async. This is more complex to fix. We may want to combine this with a redesign of the middleware macro, which has confusing behavior. This is why the macro_example program is disabled.

These two items mean the only way to write an async middleware is to implement the Middleware trait. A number of the example programs demonstrate how to do this.

plugins are disabled due to the plugin crate not not being able to be restricted to Sync + Send. The plugin crate may be abandoned, so fixing this may be a headache.
Response::on_send is currently disabled. Feedback on its use cases is needed, in particular does it need to be async, which is more complex.

…nted)

GitCop · 2020-08-24T07:32:10Z

Thanks for contributing! Unfortunately, I'm here to tell you there were style issues with your Pull Request:

Commit: 148f113
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 7f01f95
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4cd09cc
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 264cd23
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 362e477
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8a828ac
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8293706
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ea3d8f1
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8ff8981
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: df8b94f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ad183a6
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 6896d75
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 63a7723
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4cb386a
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 84038c4
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ee96b9f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 399da65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 52ec773
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 51c1f51
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 72409b2
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: e13cfe6
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4bd3544
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: fe20927
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: e90ed6f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 5a7524d
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 75daf1b
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, doc
Commit: 6495879
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ee8b813
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: c00e64c
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3c91d38
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/nickel-org/nickel.rs/blob/master/contributing.md

This message was auto-generated by https://gitcop.com

therealbstern

The only trouble spots I see, from most meaningful to least, are:

there's a lot of TODO for this refactor still present
- it's not clear that they're all addressed
the loss of plugins is concerning
- I'm especially concerned about multipart
- I don't see cookies/nickel-cookies as a builtin either
there's some redundant interfaces that should be dropped (body_parser, for example)
listener.socket() appears gone, and this is a mildly interesting method to keep
origin has become pub which is probably fine but will be conceptually hard to make private again later if need be
SSL support is moved into hyper or otherwise gone?
various startup/shutdown interface stuff
- output_on_listen tested and used in some places where it's not actually making anything clearer
- output_on_listen not being used in some places where the listen socket is printed
- end is now a no-op

Overall, it looks good to me, though this would benefit from another pass to remove dead code and improve idioms.

Finally, I'm glad to see the 'mw lifetime go away but it's not obvious to me why <D: '_, '_> is used. Is this inherited from hyper changes?

examples/integration_testing.rs

examples/json.rs

examples/no_macro_response_custom_data.rs

src/body_parser.rs

src/extensions/response.rs

src/response.rs

src/server.rs

GitCop · 2021-02-20T21:14:48Z

Thanks for contributing! Unfortunately, I'm here to tell you there were style issues with your Pull Request:

Commit: 148f113
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 7f01f95
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4cd09cc
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 264cd23
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 362e477
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8a828ac
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8293706
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ea3d8f1
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 8ff8981
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: df8b94f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ad183a6
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 6896d75
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 63a7723
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4cb386a
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 84038c4
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ee96b9f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 399da65
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 52ec773
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 51c1f51
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 72409b2
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: e13cfe6
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 4bd3544
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: fe20927
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: e90ed6f
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 5a7524d
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 75daf1b
Commits must be in the following format: %{type}(%{scope}): %{description}
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert, doc
Commit: 6495879
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: ee8b813
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: c00e64c
Commits must be in the following format: %{type}(%{scope}): %{description}
Commit: 3c91d38
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/nickel-org/nickel.rs/blob/master/contributing.md

This message was auto-generated by https://gitcop.com

cburgdorf · 2021-02-21T07:48:49Z

Thank you so much for your continued support 🙏♥️

jolhoeft · 2021-02-21T07:58:40Z

You're welcome. A lot to be done before a 0.12 can release, though.

jolhoeft added 30 commits May 5, 2020 12:35

Clean up for edition 2018

148f113

Switch to edition 2018

7f01f95

Use 2018 idioms

4cd09cc

Clean up warnings

264cd23

Upgrade compiletest_rs

362e477

Update Cargo.toml and README.md

8a828ac

Partial updates for hyper 0.13 - build broken

8293706

Further updates, build broken

ea3d8f1

Signature cleanup, still broken

8ff8981

Fixes for nickel_error

df8b94f

Responder fixes

ad183a6

Type and header fixes

6896d75

More signature fixes

63a7723

It compiles!

4cb386a

Rewire server

84038c4

Just always use hyper::Body

ee96b9f

Wire up middleware to server

399da65

Get hello_world to work

52ec773

Cleanup and add set_body method to Response

51c1f51

Update a couple crates

72409b2

Enable a bunch of examples

e13cfe6

Add query parameters

4bd3544

Update extensions

fe20927

Update favicon handler

e90ed6f

Fix custom_error_handler example

5a7524d

Enable static_files_handler middleware (but send_file not yet impleme…

75daf1b

…nted)

Removed unnecessary lifetimes

6495879

just before lifetime munging

ee8b813

More lifetime cleanup

c00e64c

Remove a bunch of lifetimes

3c91d38

jolhoeft added 12 commits August 18, 2020 22:50

Build the template example

276c53b

Merge branch 'lifetime-cleanup' into async_take2

631e1c4

Finish wiring up async middleware

eb0f99e

Async send_file implemented

042e3c3

Enable mount example

7f2081e

Enable async template reading

2ce21ab

Update the enable_cors example

17805d3

Partially restore extensions

94a9f42

raw, string, and json bosy support

9b30287

Warning cleanup

d24cecc

Form parsing

e3849a7

Warning and stale code cleanup

3ec6a6a

jolhoeft changed the title ~~Upgrade to hyper-0.13.x~~ chore(*): Upgrade to hyper-0.13.x Aug 24, 2020

jolhoeft mentioned this pull request Aug 24, 2020

Upgrade to support hyper 0.14 #402

Open

therealbstern approved these changes Oct 3, 2020

View reviewed changes

jolhoeft added 3 commits February 20, 2021 12:39

Warning cleanup

5e6ef68

Switch to the chrono crate

19fe1d0

Update compiletest_rs

d00c5f1

Update hyper and tokio

ae0d288

jolhoeft changed the title ~~chore(*): Upgrade to hyper-0.13.x~~ chore(*): Upgrade to hyper-0.14.x Feb 20, 2021

jolhoeft added 2 commits February 20, 2021 14:06

Update rust versions

15f5228

Spelling fix

c2de61c

jolhoeft merged commit 7d12245 into nickel-org:master Feb 21, 2021

This was referenced Feb 21, 2021

WIP: Hyper 11 #413

Closed

chore(*): Move to hyper 0.11.x #410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(*): Upgrade to hyper-0.14.x #459

chore(*): Upgrade to hyper-0.14.x #459

jolhoeft commented Aug 24, 2020 •

edited

Loading

GitCop commented Aug 24, 2020

therealbstern left a comment •

edited

Loading

GitCop commented Feb 20, 2021

cburgdorf commented Feb 21, 2021

jolhoeft commented Feb 21, 2021

chore(*): Upgrade to hyper-0.14.x #459

chore(*): Upgrade to hyper-0.14.x #459

Conversation

jolhoeft commented Aug 24, 2020 • edited Loading

GitCop commented Aug 24, 2020

therealbstern left a comment • edited Loading

Choose a reason for hiding this comment

GitCop commented Feb 20, 2021

cburgdorf commented Feb 21, 2021

jolhoeft commented Feb 21, 2021

jolhoeft commented Aug 24, 2020 •

edited

Loading

therealbstern left a comment •

edited

Loading