Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial fixes for desktop file #18

Closed
cwickert opened this issue Mar 3, 2012 · 2 comments
Closed

Trivial fixes for desktop file #18

cwickert opened this issue Mar 3, 2012 · 2 comments

Comments

@cwickert
Copy link

cwickert commented Mar 3, 2012

Here are two small fixes for the desktop file:

  1. Added TryExec, so the menu entry will not show up if pnmixer is not available/executable
  2. added categories 'Mixer' and 'GTK'.

From add5de45a6a35aa41748ef9744dd4eb9588dbe03 Mon Sep 17 00:00:00 2001
From: Christoph Wickert cwickert@fedoraproject.org
Date: Sat, 3 Mar 2012 21:14:38 +0100
Subject: [PATCH] Minor fixes of the desktop file


data/pnmixer.desktop | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/data/pnmixer.desktop b/data/pnmixer.desktop
index 3f61da1..2aadfa0 100644
--- a/data/pnmixer.desktop
+++ b/data/pnmixer.desktop
@@ -9,7 +9,8 @@ Comment=An audio mixer for the system tray
Comment[de]=Ein Audiomixer für das Benachrichtigungsfeld
Comment[fr]=Un Mixeur Audio pour la Zone de Notification
Exec=pnmixer
+TryExec=pnmixer
Icon=pnmixer
Terminal=false
Type=Application
-Categories=Application;AudioVideo;
\ No newline at end of file

+Categories=Application;AudioVideo;Mixer;GTK;

1.7.6.5

@cwickert
Copy link
Author

This is what the patch should look like

--- a/data/pnmixer.desktop
+++ b/data/pnmixer.desktop
@@ -9,7 +9,8 @@ Comment=An audio mixer for the system tray
Comment[de]=Ein Audiomixer für das Benachrichtigungsfeld
Comment[fr]=Un Mixeur Audio pour la Zone de Notification
Exec=pnmixer
+TryExec=pnmixer
Icon=pnmixer
Terminal=false
Type=Application
-Categories=Application;AudioVideo;
\ No newline at end of file
+Categories=Audio;AudioVideo;Mixer;GTK;

The category 'Application' is obsolete, on the other hand everything that has 'AudioVideo' also needs 'Audio'

hasufell added a commit to hasufell/pnmixer that referenced this issue Jun 29, 2014
hasufell added a commit to hasufell/pnmixer that referenced this issue Jun 29, 2014
@hasufell
Copy link
Collaborator

hasufell commented Jul 8, 2014

7662851

@hasufell hasufell closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants