Do not extend Guzzle\Client #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending Guzzle\Client is deprecated since Guzzle 7.1 and the class is annotated as @Final. The class will be actually final in Guzzle 8.0
Brandin
approved these changes
May 28, 2021
|
I have no objection to these changes but I want @echosa to do a review before I merge it. |
|
Tested in production, no errors. |
This was referenced Jun 2, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing a small PR to fix a deprecation warning when using Guzzle 7.1+
Extending Guzzle\Client is deprecated since Guzzle 7.1 and the class is annotated as @final. The class will be actually final in Guzzle 8.0.
See guzzle/guzzle#2521
This would be a BC change, but since you're thinking of making a 5.0 release, this would be the time.