Add new void rule example and tests

nicklockwood · Aug 15, 2020 · 628ff49 · 628ff49
1 parent 3ae5d97
commit 628ff49
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/Sources/Examples.swift b/Sources/Examples.swift
@@ -953,6 +953,11 @@ private struct Examples {
     - func quux() -> (Void)
     + func quux() -> Void
     ```
+
+    ```diff
+    - callback = { _ in Void() }
+    + callback = { _ in () }
+    ```
     """
 
     let wrapArguments = """

diff --git a/Tests/RulesTests.swift b/Tests/RulesTests.swift
@@ -4876,6 +4876,26 @@ class RulesTests: XCTestCase {
         testFormatting(for: input, output, rule: FormatRules.void)
     }
 
+    func testVoidLiteralReturnValueConvertedToParens() {
+        let input = """
+        func foo() {
+            return Void()
+        }
+        """
+        let output = """
+        func foo() {
+            return ()
+        }
+        """
+        testFormatting(for: input, output, rule: FormatRules.void)
+    }
+
+    func testVoidLiteralReturnValueConvertedToParens2() {
+        let input = "{ _ in Void() }"
+        let output = "{ _ in () }"
+        testFormatting(for: input, output, rule: FormatRules.void)
+    }
+
     func testNamespacedVoidLiteralNotConverted() {
         let input = "let foo = Swift.Void()"
         testFormatting(for: input, rule: FormatRules.void)

diff --git a/Tests/XCTestManifests.swift b/Tests/XCTestManifests.swift
@@ -1843,6 +1843,8 @@ extension RulesTests {
         ("testVoidClosureReturnValueConvertedToEmptyTuple", testVoidClosureReturnValueConvertedToEmptyTuple),
         ("testVoidLiteralConvertedToParens", testVoidLiteralConvertedToParens),
         ("testVoidLiteralConvertedToParens2", testVoidLiteralConvertedToParens2),
+        ("testVoidLiteralReturnValueConvertedToParens", testVoidLiteralReturnValueConvertedToParens),
+        ("testVoidLiteralReturnValueConvertedToParens2", testVoidLiteralReturnValueConvertedToParens2),
         ("testVoidThrowsIsNotMangled", testVoidThrowsIsNotMangled),
         ("testWhileAndReplaced", testWhileAndReplaced),
         ("testWhileNotAffectedByElseOnSameLineIfNotRepeatWhile", testWhileNotAffectedByElseOnSameLineIfNotRepeatWhile),