More organizeDeclarations improvements #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
force-pushed
the
cal--organize-decls-improvements-0.46.1
branch
2 times, most recently
from
1dc86c0
to
768a7b6
Compare
nicklockwood
force-pushed
the
cal--organize-decls-improvements-0.46.1
branch
from
0fd3811
to
1943906
Compare
bachand
reviewed
Aug 31, 2020
| // we'll want to replace the existing comment with the correct comment. | ||
| let existingComment = sourceCode(for: Array(parser.tokens[potentialSeparatorRange])) | ||
|
|
||
| guard editDistance(existingComment.lowercased(), potentialSeparatorComment.lowercased()) <= 3 else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to the
organizeDeclarationsrule (#701) based on discussions from airbnb/swift#102:typealiasdeclarations with types instead of with propertiesinstancePropertydeclarations, but they are actually more type-like)blankLinesAtEndOfScoperule