Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request to 2.75.0 #140

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

scriptdaemon
Copy link
Contributor

This update seems to have been reverted during a merge.

@coveralls
Copy link

coveralls commented Sep 17, 2016

Coverage Status

Coverage remained the same at 94.932% when pulling e15e09a on scriptdaemon:update-request-dep into 8fcaec4 on nickmerwin:master.

@alexindigo
Copy link

It makes all the analysis tools very unhappy, because this: https://snyk.io/vuln/npm:tough-cookie:20160722

security

Thank you.

/cc @nickmerwin

@alexindigo
Copy link

Btw @scriptdaemon @nickmerwin there is new version of request – 2.74.1 (I noticed you strict versions) and it's takes 5MB less on disk (dropped async with lodash). So you might want to bump right to it.

Thank you.

@scriptdaemon scriptdaemon changed the title Re-update request to 2.74.0 Update request to 2.74.1 Sep 17, 2016
@scriptdaemon
Copy link
Contributor Author

@alexindigo Updated to 2.74.1.

@alexindigo
Copy link

Sorry man, they updated package.json, but yet to push it to npm :(
I pinged them in the comments.

@scriptdaemon
Copy link
Contributor Author

@alexindigo Eh, as long as they do it quickly this can wait, Otherwise I'll revert.

@alexindigo
Copy link

For sure. When I saw it in package.json I assumed it was pushed to npm.

@alexindigo
Copy link

@scriptdaemon Looks like it was some random confusing fluke, with the patch version :) – request/request#2379 (comment)

@alexindigo
Copy link

Ok, 2.75.0 is out. https://www.npmjs.com/package/request

This update seems to have been reverted during a merge.
@scriptdaemon scriptdaemon changed the title Update request to 2.74.1 Update request to 2.75.0 Sep 18, 2016
@scriptdaemon
Copy link
Contributor Author

@alexindigo Done.

@coveralls
Copy link

coveralls commented Sep 18, 2016

Coverage Status

Coverage remained the same at 94.932% when pulling bfc1206 on scriptdaemon:update-request-dep into 8fcaec4 on nickmerwin:master.

@alexindigo
Copy link

Thank you @scriptdaemon

@nickmerwin Please let us know if we can help to expedite it in any way. Thank you.

@nickmerwin
Copy link
Owner

@alexindigo @scriptdaemon thank you! Publishing now.

@nickmerwin nickmerwin merged commit 9955dc6 into nickmerwin:master Sep 19, 2016
@alexindigo
Copy link

Thank you @nickmerwin

@scriptdaemon scriptdaemon deleted the update-request-dep branch September 20, 2016 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants