Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated form-data to v2.0.0 #2379

Closed
wants to merge 1 commit into from

Conversation

@alexindigo
Copy link
Contributor Author

PS. On totally unrelated note, October 2016 is around the corner, do you think it's time to drop 0.10? :)

@mscdex
Copy link
Contributor

mscdex commented Sep 17, 2016

Heh one step ahead of you (and one step behind greenkeeper bot): #2378 :-)

@alexindigo
Copy link
Contributor Author

Haha :) it's nice to have something to choose from :)
Thank you btw for going all the way. :)

@simov
Copy link
Member

simov commented Sep 17, 2016

@alexindigo we should probably drop support for anything below LTS at some point. I already excluded a few dependencies from greenkeeper because of ES* features used https://github.com/request/request/pull/2353/files

@simov
Copy link
Member

simov commented Sep 17, 2016

I mean LTS 4 :)

@alexindigo
Copy link
Contributor Author

I think 0.12 is used a lot in enterprise environments. Probably we can ask npm folks to publish stats on node versions talking to them.

And yes eslint+greenkeeper was most annoying thing :) So I created is-node-modern, so it'd run eslint only in newer node environments but I still can ci older versions. :)

I'll put back 0.10 support if you guys want to keep it after October. Right it now it works so it's just matter of travis-ci confing to prevent future breaks.

@alexindigo
Copy link
Contributor Author

@simov Do you mind to publish new version to npm? Or you not sure if it's patch change?

@simov
Copy link
Member

simov commented Sep 17, 2016

We use only minor versions here, totally not following semver. I'll remove 0.10 from TravisCI and I'll publish it.

@alexindigo
Copy link
Contributor Author

I see. I just noticed 2.74.1 in the package.json and thought you already started publishing process. :)

Thank you.

@simov
Copy link
Member

simov commented Sep 17, 2016

Done ✨

The version is 2.75.0

@alexindigo
Copy link
Contributor Author

Awesome thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants