Calc refactoring #63
Merged
Calc refactoring #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickovchinnikov
force-pushed
the
nick/calc
branch
from
552ce0d
to
2b4fdee
Compare
vvscode
reviewed
Sep 13, 2020
scripts/calc/engine.ts
Outdated
| trigonomenticOperators, | ||
| } from "./mathOperators"; | ||
|
|
||
| const [ZERO, FIRST, SECOND, THIRD, FOURTH] = mathPriorities; | ||
| const { ZERO, FIRST, SECOND, THIRD, FOURTH } = MathPrioritiesList; |
There was a problem hiding this comment.
имхо, но я бы PascalCase оставлял для типов и конструкторов
vvscode
reviewed
Sep 13, 2020
scripts/calc/engine.ts
Outdated
| import { | ||
| isOperator, | ||
| isTrigonometricOperator, | ||
| checkerMathOperatorsPriorities, |
There was a problem hiding this comment.
имхо, но методы стоит глаголами называть, а не существительными
потому что глядя на имя функции вообще не ясно, что и как она делает (ну да, проверяет, но что это значит?)
is... ?
There was a problem hiding this comment.
checkMathOperatorsPriorities - так норм?
vvscode
reviewed
Sep 13, 2020
scripts/calc/helpers.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| if (!Array.isArray(priorities)) { |
There was a problem hiding this comment.
может в таком случае привести к массиву и дальше по стандартной схеме ниже?
vvscode
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.