Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EOL Options (rely on xparse correctly parsing up to the invalid delim) #28

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Remove EOL Options (rely on xparse correctly parsing up to the invalid delim) #28

merged 5 commits into from
Oct 21, 2021

Commits on Oct 20, 2021

  1. Remove EOL options as we can just rely on calling next_line 

    I think we decided we didn't need this, right?
    @quinnj @nickrobinson251
    quinnj authored and nickrobinson251 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    53f3a9d View commit details
    Browse the repository at this point in the history

  2. fix fieldcount call

    @nickrobinson251
    nickrobinson251 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    61158c8 View commit details
    Browse the repository at this point in the history

  3. Don't log warning when invaliddelim expected

    @nickrobinson251
    nickrobinson251 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    cd05b6a View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary code 

    - this was needed when we were changing
  the delim to the comment character (`/`),
  and so wouldn't hit `newline` if there
  was a comment.
- now that we expect parsing to work
  even when there's an invalid character
  (the comment character `/`), parsing
  should still consume the whole line
  and hit the newline character.
    @nickrobinson251
    nickrobinson251 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ee24c5a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Lower-bound Parsers.jl

    @nickrobinson251
    nickrobinson251 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    dee4635 View commit details
    Browse the repository at this point in the history