Remove EOL Options (rely on xparse correctly parsing up to the invalid delim)
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we decided we didn't need this, right?
- this was needed when we were changing the delim to the comment character (`/`), and so wouldn't hit `newline` if there was a comment. - now that we expect parsing to work even when there's an invalid character (the comment character `/`), parsing should still consume the whole line and hit the newline character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases #14 and adds some further clean up
Blocked until JuliaData/Parsers.jl#93 is resolved
Currently we handle lines rows with end-of-line (EOL) comments by changing the
Optionsto havedelim='/'(where/is the comment character), and then callingnext_lineto consume / move past the comment.But we can instead relying on
xparseto be robust to the presence of the comment, i.e. to correctly parse the value up until it hits the comment character. It seems this will also consume the rest of the line too (i.e. it parsers til it hits the newline). The result code fromxparsewill then be"INVALID: OK | NEWLINE | INVALID_DELIMITER ", so we just need to handle that (i.e. ignore it, rather than warning like we usually would) and everything should be fine... hopefully 馃槀This simplifies the existing code, and should make changes like #23 simpler too.