Tidy up some code in parsing.jl #8

nickrobinson251 · 2021-09-20T18:02:09Z

Mostly this is to simplify code... it could possibly help parsing time, but @btime doesn't say so.

avoid recreating options (creating Options is actually really cheap, but still unnecessary to do it per file to be parsed), and simplify some of the code inside the parsing functions
annotate parse_record! return type because @code_warntype seemed to not be able to work it out

nickrobinson251 added 5 commits September 20, 2021 18:16

Only create 'end-of-line Options` once per file

6eb52c8

Only create Options objects once

c8cd7d2

Use ifelse to avoid potential branch

3c54f47

Annotate return to help inference

6beb55a

Remove unnecessary incr! calls

c50f558

nickrobinson251 merged commit ad0c56f into main Sep 21, 2021

nickrobinson251 deleted the npr/reuse-options branch October 23, 2021 10:18

Provide feedback