Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract concatenated strings #143

Merged
merged 2 commits into from
Nov 23, 2018
Merged

extract concatenated strings #143

merged 2 commits into from
Nov 23, 2018

Conversation

nicksnyder
Copy link
Owner

fixes #142

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #143 into master will decrease coverage by 0.04%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   67.63%   67.58%   -0.05%     
==========================================
  Files          28       28              
  Lines        2283     2298      +15     
==========================================
+ Hits         1544     1553       +9     
- Misses        660      663       +3     
- Partials       79       82       +3
Impacted Files Coverage Δ
v2/goi18n/extract_command.go 63.07% <57.89%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebaecb...c410025. Read the comment docs.

@nicksnyder nicksnyder merged commit 178b9fc into master Nov 23, 2018
@nicksnyder nicksnyder deleted the extract-concat-string branch November 23, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goi18n extract does not see messages with concatenations
1 participant