Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .golangci.yml #144

Merged
merged 1 commit into from
Nov 26, 2018
Merged

add .golangci.yml #144

merged 1 commit into from
Nov 26, 2018

Conversation

jirfag
Copy link
Contributor

@jirfag jirfag commented Nov 24, 2018

This pull request fixes warning on fetching dependencies in golangci.com analysis

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files          28       28           
  Lines        2298     2298           
=======================================
  Hits         1553     1553           
  Misses        663      663           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0db6e...c36edc7. Read the comment docs.

@nicksnyder
Copy link
Owner

Thanks for reaching out! As you saw, I was also experimenting with go mod download in #145. Is there any reason to prefer one over the other?

@jirfag
Copy link
Contributor Author

jirfag commented Nov 26, 2018

I prefer go get because it works. go mod doesn't work as you see in this output - I will try to investigate it and suggest solution with go modules tomorrow

@nicksnyder nicksnyder merged commit cc0ca3b into nicksnyder:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants