Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to v2 subfolder for greater compatibility #187

Merged
merged 5 commits into from
Jun 11, 2019
Merged

Move code to v2 subfolder for greater compatibility #187

merged 5 commits into from
Jun 11, 2019

Conversation

nicksnyder
Copy link
Owner

So projects who are still using Glide or Dep can continue to depend on the latest version of go-i18n.

Related to #179 and #184

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #187   +/-   ##
======================================
  Coverage    82.9%   82.9%           
======================================
  Files          14      14           
  Lines        1293    1293           
======================================
  Hits         1072    1072           
  Misses        158     158           
  Partials       63      63
Impacted Files Coverage Δ
v2/internal/plural/operands.go 67.64% <ø> (ø)
v2/i18n/bundle.go 59.61% <ø> (ø)
v2/internal/plural/rules.go 100% <ø> (ø)
v2/i18n/localizer.go 80.43% <ø> (ø)
v2/internal/template.go 90.47% <ø> (ø)
v2/i18n/message_template.go 92.85% <ø> (ø)
v2/i18n/parse.go 73.11% <ø> (ø)
v2/internal/plural/rule.go 100% <ø> (ø)
v2/i18n/message.go 87.71% <ø> (ø)
v2/goi18n/merge_command.go 74.43% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e77af...bc8f1c6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #187   +/-   ##
======================================
  Coverage    82.9%   82.9%           
======================================
  Files          14      14           
  Lines        1293    1293           
======================================
  Hits         1072    1072           
  Misses        158     158           
  Partials       63      63
Impacted Files Coverage Δ
v2/internal/plural/operands.go 67.64% <ø> (ø)
v2/i18n/bundle.go 59.61% <ø> (ø)
v2/internal/plural/rules.go 100% <ø> (ø)
v2/i18n/localizer.go 80.43% <ø> (ø)
v2/internal/template.go 90.47% <ø> (ø)
v2/i18n/message_template.go 92.85% <ø> (ø)
v2/i18n/parse.go 73.11% <ø> (ø)
v2/internal/plural/rule.go 100% <ø> (ø)
v2/i18n/message.go 87.71% <ø> (ø)
v2/goi18n/merge_command.go 74.43% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e77af...5d6aad9. Read the comment docs.

v2/i18n/bundle.go Outdated Show resolved Hide resolved
This reverts commit c747581.
@nicksnyder nicksnyder marked this pull request as ready for review June 11, 2019 17:04
@nicksnyder nicksnyder merged commit 0c6ce6a into master Jun 11, 2019
@nicksnyder nicksnyder deleted the v2 branch June 11, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants