-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store configuration and ServerPool on the app #78
Conversation
I need to rebase this to resolve the conflicts with blackening the code in #81. |
2682858
to
e8e1d6b
Compare
OK, I've rebased this to resolve the formatting conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should make flake8 happier.
e8e1d6b
to
50e9469
Compare
I tripped over psf/black#1202. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to merge even with decreased coverage.
This is the second PR addressing #40. The configuration is now always read from the current app. While working on this, I realized that the ServerPool is more like configuration that state since it doesn't hold on to open connections. (i.e. it isn't a connection pool). I therefore stored it on the app, too.