Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added storybook #72

Merged
merged 3 commits into from Oct 30, 2022

Conversation

YolandaHaynes
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Refactor
  • Optimization

Description

Added storybook to the project.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

to run story book:
run npm run storybook

UI accessibility concerns?

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] What gif best describes this PR or how it makes you feel?

nail biting

@nickytonline
Copy link
Owner

nickytonline commented Oct 29, 2022

Thanks for the pull request @YolandaHaynes! It looks like the site isn't building because of code formatting issues.


11:02:17 PM: ​
11:02:17 PM: $ npm run build
11:02:18 PM: > connect-four@1.0.0 prebuild
11:02:18 PM: > npm run lint && CI=true npm test -- run --coverage
11:02:18 PM: > connect-four@1.0.0 lint
11:02:18 PM: > prettier --plugin-search-dir . --check . && eslint .
11:02:18 PM: Checking formatting...
11:02:18 PM: [warn] .eslintrc.cjs
11:02:18 PM: [warn] .storybook/main.cjs
11:02:18 PM: [warn] .storybook/preview-head.html
11:02:18 PM: [warn] .storybook/preview.cjs
11:02:18 PM: [warn] package.json
11:02:19 PM: [warn] src/stories/button.css
11:02:19 PM: [warn] src/stories/Button.stories.js
11:02:19 PM: [warn] src/stories/Button.svelte
11:02:19 PM: [warn] src/stories/header.css
11:02:19 PM: [warn] src/stories/Header.stories.js
11:02:19 PM: [warn] src/stories/Header.svelte
11:02:19 PM: [warn] src/stories/Introduction.stories.mdx
11:02:19 PM: [warn] src/stories/page.css
11:02:19 PM: [warn] src/stories/Page.stories.js
11:02:19 PM: [warn] src/stories/Page.svelte
11:02:19 PM: [warn] Code style issues found in 15 files. Forgot to run Prettier?
11:02:19 PM: ​
11:02:19 PM: ────────────────────────────────────────────────────────────────
11:02:19 PM:   "build.command" failed                                        
11:02:19 PM: 

If you run npm run format from the command line in the root folder of your branch and push up those changes, this should be good to merge.

@nickytonline nickytonline added the dx Anything related to Developer Experience label Oct 29, 2022
@nickytonline nickytonline changed the title added storybook feat: added storybook Oct 30, 2022
@YolandaHaynes
Copy link
Contributor Author

@nickytonline thanks for the tip! ok, made the changes 🤞
let's try this again

Copy link
Owner

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and all good! Thanks for the pull request @YolandaHaynes! 🚀

CleanShot 2022-10-30 at 19 28 30

@nickytonline nickytonline merged commit 7d87596 into nickytonline:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Anything related to Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Storybook to the project
2 participants