Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Support the Switch SNES Controller #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ChadSikorra
Copy link

This makes some changes so that it works with the Switch SNES controller. The SNES controller lacks some of the features of the joycons / pro controller, so I had to add some additional checks to leave things out (gyro, rumble, home button are all missing on the SNES controller).

@ChadSikorra ChadSikorra changed the title Suppert the Switch SNES Controller Support the Switch SNES Controller Jan 10, 2021
(ctlr->ctlr_type == JOYCON_CTLR_TYPE_JCR || \
ctlr->ctlr_type == JOYCON_CTLR_TYPE_PRO)

/* Does this controller have a home button? */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home button -> rumble

@nicman23
Copy link
Owner

nicman23 commented Feb 1, 2021

can anyone confirm that the above works with master and i ll merge it

@ChadSikorra
Copy link
Author

If anyone wants to test it they'll probably want to use the changes in joycond here too:

DanielOgorchock/joycond#54

@v1993
Copy link
Contributor

v1993 commented Feb 2, 2021

@ChadSikorra You may want to submit this PR to https://github.com/DanielOgorchock/linux as well I think

@ChadSikorra
Copy link
Author

This somehow messes up pro-controller support...kernel panic :( *sigh* Trying to debug. Not sure specifically what would've done that after looking at what I changed. Will have to take a closer look, unless someone can spot it.

… it, even it not supported). Just ignore the IMU data if not available.
@ChadSikorra
Copy link
Author

I modified it slightly so that it still lets certain things to be enabled via the protocol -- rumble / imu (which just ignores things certain controllers don't support it seems). This makes the driver behave better when both SNES / pro controller / joy cons are used. I tested with the Pro Controller and the SNES controller.

@trungtangg
Copy link

Any update on pulling this in?

@nicman23
Copy link
Owner

i mean i cannot really test it ... i only got joycons and pro controllers..

if anyone can for a week or so and does not find any issues i ll pull it after testing for regressions

@AdamHNix
Copy link

Been trying to test this, but unable to connect the SNES Controller in the first place. RetroPi recognizes it as paired, but the SNES controller gets stuck in pairing mode. Getting the error "Failed to pair: org.bluez.Error.AlreadyExists." Has anybody else had luck pairing the controller?

@nfp0
Copy link

nfp0 commented Feb 25, 2022

I don't understand.
My SNES controller works without the need for this DKMS. What additional functionality does this DKMS bring for the SNES controller?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants