feat: lang document is now optional + consistent field namings

/spend 2m
nico-i · Mar 31, 2024 · b2702d5 · b2702d5
1 parent cd310f2
commit b2702d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/entities/cert/cert.ts b/src/entities/cert/cert.ts
@@ -12,7 +12,7 @@ export class Cert extends LocalizedEntity {
     locale: Locale,
     public readonly issuer: string,
     received: string | Date,
-    public readonly infoMdStr: Markdown,
+    public readonly mdInfo: Markdown,
     public readonly doc?: Doc,
     public readonly url?: InstanceType<typeof URL>
   ) {

diff --git a/src/entities/lang/repo/strapi/strapi-lang-repo.ts b/src/entities/lang/repo/strapi/strapi-lang-repo.ts
@@ -1,7 +1,6 @@
 import { InvalidLocalizedEntityError } from "@/entities/entity";
 import { Lang } from "@/entities/lang";
 import {
-  InvalidLangDocError,
   InvalidLangIconError,
   type LangRepo,
 } from "@/entities/lang/repo/lang-repo";
@@ -35,16 +34,17 @@ export class StrapiLangRepo implements LangRepo {
       }
       langIcon = new Svg(new URL(icon.data.attributes.url));
 
-      let langDoc: Doc | undefined = undefined;
-      if (resLang.attributes.doc) {
-        if (!resLang.attributes.doc.data?.attributes?.url) {
-          throw new InvalidLangDocError("url not found in doc data attributes");
-        }
-        langDoc = new Doc(new URL(resLang.attributes.doc.data.attributes.url));
-      }
-
       langs.push(
-        new Lang(resLang.id, new Locale(locale), name, langIcon, level, langDoc)
+        new Lang(
+          resLang.id,
+          new Locale(locale),
+          name,
+          langIcon,
+          level,
+          resLang.attributes.doc?.data?.attributes?.url
+            ? new Doc(new URL(resLang.attributes.doc.data.attributes.url))
+            : undefined
+        )
       );
     }