-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft implementation of sample_weight
for kmodes.
#174
Conversation
0230663
to
b4bedc0
Compare
19a4faa
to
1174c33
Compare
Hi @nicodv ! Unfortunately I'm not able to recreate the test failure locally with python 3.10.4. Locally, both values in question amount to Do you have a hunch on what could be going on here? |
@kklein , I think it would be wise to use a static random seed to all your tests ( I'm hoping it will eliminate any test failures due to random variations in the algorithms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for going the full stretch, @kklein !
@@ -495,17 +495,18 @@ def _k_prototypes_iter(Xnum, Xcat, centroids, cl_attr_sum, cl_memb_sum, cl_attr_ | |||
rindx = random_state.choice(choices) | |||
|
|||
cl_attr_sum, cl_memb_sum = _move_point_num( | |||
Xnum[rindx], old_clust, from_clust, cl_attr_sum, cl_memb_sum | |||
Xnum[rindx], old_clust, from_clust, cl_attr_sum, cl_memb_sum, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find, small oversight from last PR
Please merge if you think it's ready, @kklein . FYI, I'll be making a |
Thanks for the fast review! :) |
No description provided.