fix apache#1230: make some commands to work offline

e2e/offline_commands_test.go

@@ -0,0 +1,41 @@
+// +build integration
+
+// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration"
+
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package e2e
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestKamelVersionWorksOffline(t *testing.T) {
+	assert.Nil(t, kamel("version", "--config", "non-existent-kubeconfig-file").Execute())
+}
+
+func TestKamelHelpTraitWorksOffline(t *testing.T) {
+	assert.Nil(t, kamel("help", "trait", "--all", "--config", "non-existent-kubeconfig-file").Execute())
+}
+
+func TestKamelCompletionWorksOffline(t *testing.T) {
+	assert.Nil(t, kamel("completion", "bash", "--config", "non-existent-kubeconfig-file").Execute())
+	assert.Nil(t, kamel("completion", "zsh", "--config", "non-existent-kubeconfig-file").Execute())
+}

pkg/cmd/completion_bash.go

@@ -188,6 +188,9 @@ func newCmdCompletionBash(root *cobra.Command) *cobra.Command {
 				fmt.Print(err.Error())
 			}
 		},
+		Annotations: map[string]string{
+			offlineCommandLabel: "true",
+		},
 	}
 }
 

pkg/cmd/completion_zsh.go

@@ -54,6 +54,9 @@ func newCmdCompletionZsh(root *cobra.Command) *cobra.Command {
 				fmt.Print(err.Error())
 			}
 		},
+		Annotations: map[string]string{
+			offlineCommandLabel: "true",
+		},
 	}
 }
 

pkg/cmd/root.go

@@ -144,7 +144,7 @@ func addHelpSubCommands(cmd *cobra.Command, options *RootCmdOptions) error {
 }
 
 func (command *RootCmdOptions) preRun(cmd *cobra.Command, _ []string) error {
-	if command.Namespace == "" {
+	if command.Namespace == "" && !isOfflineCommand(cmd) {
 		var current string
 		client, err := command.GetCmdClient()
 		if err != nil {

pkg/cmd/trait_help.go

@@ -52,6 +52,9 @@ func newTraitHelpCmd(rootCmdOptions *RootCmdOptions) (*cobra.Command, *traitHelp
 			}
 			return options.run(args)
 		},
+		Annotations: map[string]string{
+			offlineCommandLabel: "true",
+		},
 	}
 
 	cmd.Flags().Bool("all", false, "Include all traits")

pkg/cmd/util.go

@@ -38,6 +38,10 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+const (
+	offlineCommandLabel = "camel.apache.org/cmd.offline"
+)
+
 // DeleteIntegration --
 func DeleteIntegration(ctx context.Context, c client.Client, name string, namespace string) error {
 	integration := v1.Integration{
@@ -218,3 +222,7 @@ func stringToSliceHookFunc(comma rune) mapstructure.DecodeHookFunc {
 func cmdOnly(cmd *cobra.Command, options interface{}) *cobra.Command {
 	return cmd
 }
+
+func isOfflineCommand(cmd *cobra.Command) bool {
+	return cmd.Annotations[offlineCommandLabel] == "true"
+}

pkg/cmd/version.go

@@ -33,5 +33,8 @@ func newCmdVersion() *cobra.Command {
 		Run: func(_ *cobra.Command, _ []string) {
 			fmt.Println("Camel K Client " + defaults.Version)
 		},
+		Annotations: map[string]string{
+			offlineCommandLabel: "true",
+		},
 	}
 }