Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batinfo not in docker image (and in requirements files...) ? #1915

Closed
khaffner opened this issue Aug 8, 2021 · 1 comment
Closed

batinfo not in docker image (and in requirements files...) ? #1915

khaffner opened this issue Aug 8, 2021 · 1 comment
Labels
bug dependencies Pull requests that update a dependency file
Milestone

Comments

@khaffner
Copy link

khaffner commented Aug 8, 2021

Describe the bug
batinfo seems to not be in docker image. I have a laptop (Thinkpad T570) with 3 batteries, including the wireless mouse. batinfo and UPower can show all the information about these batteries, and I'd like them to show up in Glances.

To Reproduce
Steps to reproduce the behavior:

  1. docker run -it nicolargo/glances python
  2. >>> import batinfo
  3. "ModuleNotFoundError: No module named 'batinfo'"

Expected behavior
Looking at the code (I'm not too familiar with python though), a missing batinfo seems to be expected in non-linux environments. But this environment (allthough docker) is Linux.

Screenshots
I believe I got something working interactively using batinfo
image

Desktop (please complete the following information):

  • OS: (Docker 20.10.8 on) Pop OS 20.04 (based on Ubuntu)
  • Glances Version [Glances v3.1.6.2 with PsUtil v5.8.0]
  • Glances logs file:
    root@57662d45c772:/glances# tail -10 /tmp/glances-root.log
    2021-08-08 16:41:05,583 -- INFO -- Start Glances 3.1.6.2
    2021-08-08 16:41:05,583 -- INFO -- CPython 3.9.4 and psutil 5.8.0 detected
  • Glances test [output of glances --issue] (only available with Glances 3.1.7 or higher)

Additional context
I also tried to create a new image based on the latest tag, and just added RUN pip install batinfo. That did not solve the issue, and I do not know what to try next.

@nicolargo nicolargo changed the title batinfo not in docker image? batinfo not in docker image (and in requirements files...) ? Aug 14, 2021
@nicolargo
Copy link
Owner

The issue came from the fact that the batinfo dep was not in the optional-requirements.txt file (do not remember why...).

I just add it.

So the the problem will be solve when Glances 3.2.3 will be release.

@nicolargo nicolargo added bug dependencies Pull requests that update a dependency file labels Aug 14, 2021
@nicolargo nicolargo added this to the Glances 3.2.3 milestone Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants