Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore/detect symlink loops in folders plugin #2494

Closed
Ellpeck opened this issue Jul 10, 2023 · 2 comments
Closed

Ignore/detect symlink loops in folders plugin #2494

Ellpeck opened this issue Jul 10, 2023 · 2 comments

Comments

@Ellpeck
Copy link

Ellpeck commented Jul 10, 2023

Is your feature request related to a problem? Please describe.
Currently, the folders plugin displays a ? for any folders that have symlink loops in them, like the /var/lib/docker directory, for example.

When enabling the debug flag, the following info is displayed in the log file:

-- DEBUG -- Cannot get folder size (/var/lib/docker). Error: [Errno 40] Symbolic link loop: [...]

Describe the solution you'd like
I think it would make sense if the error described above would be caught in the folders plugin, and the true size of the folder without the symlink loop would be displayed, instead of a ?.

Tools like ncdu already do this, and Glances' file system plugin seems to deal fine with symlinks already.

Thanks so much for this great tool, and thanks for possibly considering my suggestion!! ❤️

@nicolargo
Copy link
Owner

Hi @Ellpeck

Thanks for the issue report :)

I just push a patch on the develop branch in order to avoid Glances Folders plugin to follow symbolic link. Glances has now the same behavor than ncdu.

Nicolas

@Ellpeck
Copy link
Author

Ellpeck commented Jul 17, 2023

Hi! I tried the change and it doesn't appear to error based on symlinks anymore now, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants